[Bug 29051] New: Seen renewal methods incorrectly blocked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Bug ID: 29051 Summary: Seen renewal methods incorrectly blocked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 24083 To recreate: 1 - turn on UnseenRenewals 2- confirm AllowRenewalLimitOverride is off 3- set your all/all rule to allow 1 unseen renewal, more than 1 regular renewal 4- check item out to patron, make sure you're following the all/all rule 5- renew item from OPAC as patron 6- confirm OPAC and intranet tell you next renewal must be at library but that you have renewals remaining 7- try to renew with the Renew Selected button in the Checkouts tab, you cannot select this checkout 8- try to renew with the Renew All button in the Checkouts tab, the item does not renew 9- try to check the item out to the patron again, get message "No more renewals possible" 10 - try to renew by putting the barcode in the big Renew box at the top of the page, get message "E Street shuffle : ( 1 ) has been renewed the maximum number of consecutive times without being seen by the library )" That leaves staff with no way to perform a Seen renewal and reset the count un Unseen renewals, which means the patron is stuck and the item must be returned, which makes this feature deeply flawed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 [Bug 24083] Koha should support "seen" vs "unseen" renewals -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, this looks like a regression.. I agree it should allow for renewal in the staff client as seen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134898&action=edit Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134899&action=edit Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK, those two patches should resolve: 7- try to renew with the Renew Selected button in the Checkouts tab, you cannot select this checkout 8- try to renew with the Renew All button in the Checkouts tab, the item does not renew Still working on the other avenues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not sure about the other two.. we don't have a clear way of saying "This wasn't a seen renewal" for them (On the table version we default to 'seen' but you have the checkbox to set 'unseen' and we handle it nicely as a result).. For the search header renew, perhaps we're OK to always assume it's 'seen' (as in theory you are always scanning into that box), but for the normal Checkout way it could be via a search.. so maybe we should not always assume 'seen' or at least give the option to do an 'unseen' at this point.. think about telephone renewals as a workflow.. What do you think Andrew? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #6 is|1 |0 private| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I reckon go with this for now and work on the other bits as a distinct bug.. I've run out of time to continue here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134898|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 136780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136780&action=edit Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134899|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 136782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136782&action=edit Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs Signoff |Signed Off --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- 7 and 8 work with the patch! Thanks Andrew and Martin, this is major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136780|0 |1 is obsolete| | Attachment #136782|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137271&action=edit Bug 29051: Enable seen renewal in the staff client This patch updates the javascript for the checkouts table to add the checkbox back in for the case where too_unseen is the error returned by CanBookBeRenewed, allowing such issues to be renewed. Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137272&action=edit Bug 29051: Update svc api to allow seen renewals This patch updates the svc/renew api endpoint to allow seen renewals when appropriate Signed-off-by: Caroline <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29051 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)|22.11.00, 22.05.05, |22.11.00, 22.05.05, released in|21.11.12 |21.11.12, 21.05.19 CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.19 Nothing to document I think. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org