[Bug 31039] New: Rebase issues lead to duplicate JS for cash summary modal printing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Bug ID: 31039 Summary: Rebase issues lead to duplicate JS for cash summary modal printing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We have duplicate JS for the cashup summary modals and this leads to double print dialogues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136488&action=edit Bug 31039: Remove duplicate modal printing JS This patch removes the erroneos duplication of the modal printing js. Test plan 1) Create some transactions and perform a cashup. 2) Open the cashup summary modal 3) Click 'Print' 4) Cancel the print dialogue 5) Note that the dialogue re-appears 6) Apply the patch 7) Repeat and note the dialogue closes first time now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org, | |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I attempted to test, but I am not seeing this problem: 1. Print 2. Opens print dialogue 3. Cancel 4. Goes back to cashup summary modal Tested using Ubuntu 18.04 with Firefox and Google Chrome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Weird.. it was consistent for Firefox and Chrome for me.. even got Owen to test it on IRC before I reported the bug and he agreed. Hmm.. wonder what's going on... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #4 from David Nind <david@davidnind.com> --- If it's any consolation, I didn't notice anything different after applying the patch. I use Firefox Developer Edition for testing (with the history/caching deleted each time it starts up). Maybe it only shows up on other operating systems? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136488|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136532&action=edit Bug 31039: Remove duplicate modal printing JS This patch removes the erroneos duplication of the modal printing js. Test plan 1) Create some transactions and perform a cashup. 2) Open the cashup summary modal 3) Click 'Print' 4) Cancel the print dialogue 5) Note that the dialogue re-appears 6) Apply the patch 7) Repeat and note the dialogue closes first time now. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 136533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136533&action=edit Bug 31039: (follow-up) Wrap jQuery in $(document).ready() cashup_modal.js consists only of jQuery code, so the whole thing should be contained in a $(document).ready() function. This may or may not be contributing to the behavior this bug is trying to fix. Please note that this patch contains whitespace changes, so diff accordingly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136533|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137046&action=edit Bug 31039: (follow-up) Wrap jQuery in $(document).ready() cashup_modal.js consists only of jQuery code, so the whole thing should be contained in a $(document).ready() function. This may or may not be contributing to the behavior this bug is trying to fix. Please note that this patch contains whitespace changes, so diff accordingly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I couldn't replicate the doubled up printing dialogues, but could also not find any regression and the changes look good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 87. Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 88. Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 158. Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 288. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136532|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137367&action=edit Bug 31039: Remove duplicate modal printing JS This patch removes the erroneos duplication of the modal printing js. Test plan 1) Create some transactions and perform a cashup. 2) Open the cashup summary modal 3) Click 'Print' 4) Cancel the print dialogue 5) Note that the dialogue re-appears 6) Apply the patch 7) Repeat and note the dialogue closes first time now. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137046|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 137368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137368&action=edit Bug 31039: (follow-up) Wrap jQuery in $(document).ready() cashup_modal.js consists only of jQuery code, so the whole thing should be contained in a $(document).ready() function. This may or may not be contributing to the behavior this bug is trying to fix. Please note that this patch contains whitespace changes, so diff accordingly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Marcel de Rooy from comment #9)
Argument "" isn't numeric in multiplication (*) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt line 86. ...
What is the purpose of this comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'll rebase on Monday, and take a look at the highlighted warnings at the same time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #14)
I'll rebase on Monday, and take a look at the highlighted warnings at the same time.
I filed the warnings already when looking at one of the other cash register patches: Bug 31125 - Fix warnings from register.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137367|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137514&action=edit Bug 31039: Remove duplicate modal printing JS This patch removes the erroneos duplication of the modal printing js. Test plan 1) Create some transactions and perform a cashup. 2) Open the cashup summary modal 3) Click 'Print' 4) Cancel the print dialogue 5) Note that the dialogue re-appears 6) Apply the patch 7) Repeat and note the dialogue closes first time now. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137368|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137515&action=edit Bug 31039: (follow-up) Wrap jQuery in $(document).ready() cashup_modal.js consists only of jQuery code, so the whole thing should be contained in a $(document).ready() function. This may or may not be contributing to the behavior this bug is trying to fix. Please note that this patch contains whitespace changes, so diff accordingly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a duplicate release notes| |print dialogue box | |appearing when printing the | |cashup summary for cash | |registers - ins some | |circumstances when | |cancelling the print | |dialogue, it reappeared | |instead of closing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985, 27779 |31121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 [Bug 27779] Cashup summary 'refunds' should denote what the refund was actioned against https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 [Bug 31121] Format date range on top of cashup summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038 [Bug 31038] Amounts in cashup summary modal no longer properly formatted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Bug 31039 depends on bug 31038, which changed state. Bug 31038 Summary: Amounts in cashup summary modal no longer properly formatted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #21 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #22 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org