[Bug 22248] New: Error when incrementing Mana comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Bug ID: 22248 Summary: Error when incrementing Mana comment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 17047 Target Milestone: --- When I select an existing Mana comment on a subscription the process completes successfully but in the console this error is returned: Can't return outside a subroutine at /home/vagrant/kohaclone/svc/mana/increment line 48. It looks like that script should return JSON. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Bug 22248 depends on bug 17047, which changed state. Bug 17047 Summary: Mana Knowledge Base : share data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 90413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90413&action=edit Bug 22248: make svc/mana/increment print valid output Test plan: - select an existing comment on a subscription - check the logs, note the error (Can't return outside a subroutine) - apply this patch - select an existing comment again - error should be gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Ian Walls <ian@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian@bywatersolutions.com --- Comment #2 from Ian Walls <ian@bywatersolutions.com> --- I cannot reproduce this error to test.... a POST to http://localhost:8081/cgi-bin/koha/svc/mana/increment returns 200 OK with no content body. Browser console is happy and quiet. Perhaps a change on Mana's end? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Any update here Alex? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Same as Ian.
200 OK with no content body. Browser console is happy and quiet.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Owen: Can you still reproduce the problem? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Magnus Enger from comment #5)
Owen: Can you still reproduce the problem?
I don't remember how I triggered the problem in the first place! I don't remember what I meant by "When I select an existing Mana comment on a subscription ..." I don't object to closing this bug if that's the consensus. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- +1 If someone else manages to reproduce it they will hopefully find this ticket. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22248 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I've tried again to reproduce this bug and have failed. I don't see any errors showing up during the subscription add process, during Mana search, or during the process of adding comments to Mana. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org