[Bug 26535] New: Remove issues old_issues redundant indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 Bug ID: 26535 Summary: Remove issues old_issues redundant indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: didier.gautheron@biblibre.com Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org issues and old_issues have redundant indexes. Removing them seems to reduce dead locks occurrences. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 This patch doesn't try to remove existing indexes it only change DB structure for new instances. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 --- Comment #1 from didier <didier.gautheron@biblibre.com> --- Created attachment 110735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110735&action=edit Bug 26535: Remove issues tables redundant indexes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Didier, I think this is good, but is there a reason not to fix the existing installations of this is causing an issue? We aim to keep the database structure in sync. There are handy methods for checking on the existence of an index in the updatedatabase script that could be useful here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 --- Comment #3 from didier <didier.gautheron@biblibre.com> --- Hi, (In reply to Katrin Fischer from comment #2)
Hi Didier,
I think this is good, but is there a reason not to fix the existing installations of this is causing an issue? We aim to keep the database structure in sync. There are handy methods for checking on the existence of an index in the updatedatabase script that could be useful here. Mostly reliability. I'm not sure testing on index name is enough, other index must exist, use the right columns, and it must be more restrictive than the deleted one.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to didier from comment #3)
Hi Didier,
I think this is good, but is there a reason not to fix the existing installations of this is causing an issue? We aim to keep the database structure in sync. There are handy methods for checking on the existence of an index in the updatedatabase script that could be useful here. Mostly reliability. I'm not sure testing on index name is enough, other index must exist, use
Hi, (In reply to Katrin Fischer from comment #2) the right columns, and it must be more restrictive than the deleted one.
Maybe remove them all and recreate then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- We may remove 'bordate' index, it is not safe to use timestamp into an index. I cant find what it is for exactly. But with ORM use, this is likly to be useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26535 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org