[Bug 40107] New: Article requests: Some DataTables functionality is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Bug ID: 40107 Summary: Article requests: Some DataTables functionality is broken Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When you change the status of an article request using the "Actions" menu, the affect row should be removed and the table redrawn. Instead there is an error in the console: Uncaught (in promise) TypeError: requested_datatable.rows is not a function UpdateTabCounts http://127.0.0.1:8081/cgi-bin/koha/circ/article-requests.pl?branchcode=:1171... SetPending http://127.0.0.1:8081/cgi-bin/koha/circ/article-requests.pl?branchcode=:1169... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183174&action=edit Bug 40107: Article requests: Some DataTables functionality is broken Bug 38255 standardized our DataTables using kohaTable. kohaTable returns the affected table as a jQuery object, but JavaScript on the article requests page in the staff client expects a DataTable object. This patch updates the template accordingly. To test, apply the patch and enable the ArticleRequests system preference if necessary. - Log in to the OPAC and place several article requests. - In the staff interface, go to Circulation -> Article requests. - From the list of new article requests, test the menu options under "Actions." - Changing the status of a request should make it disappear from the "New" tab and appear under the tab for the new status (or it should be removed, in case of cancel or complete). - Test the same processes under the "Pending" and "Processing" tabs. - Each time you perform one of these tasks the counters on each tab should be updated correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #2 from Andrii Nugged <nugged@gmail.com> --- .kohaTable() is jquery object? ... .kohaTable().DataTable(); then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |Article requests function| | Status|ASSIGNED |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Andrii Nugged from comment #2)
... .kohaTable().DataTable();
then?
In this case both the jQuery object and the DataTables object are used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183174|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 183251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183251&action=edit Bug 40107: Article requests: Some DataTables functionality is broken Bug 38255 standardized our DataTables using kohaTable. kohaTable returns the affected table as a jQuery object, but JavaScript on the article requests page in the staff client expects a DataTable object. This patch updates the template accordingly. To test, apply the patch and enable the ArticleRequests system preference if necessary. - Log in to the OPAC and place several article requests. - In the staff interface, go to Circulation -> Article requests. - From the list of new article requests, test the menu options under "Actions." - Changing the status of a request should make it disappear from the "New" tab and appear under the tab for the new status (or it should be removed, in case of cancel or complete). - Test the same processes under the "Pending" and "Processing" tabs. - Each time you perform one of these tasks the counters on each tab should be updated correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes JavaScript release notes| |errors in the staff | |interface article requests | |table. The tables weren't | |refreshing, and the tab | |numbers weren't updating, | |when selecting an action | |for individual or multiple | |requests (such as'Set | |request as pending'). Summary|Article requests: Some |Article requests: some |DataTables functionality is |DataTables functionality is |broken |broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 --- Comment #5 from Andrii Nugged <nugged@gmail.com> --- (In reply to Owen Leonard from comment #3)
In this case both the jQuery object and the DataTables object are used.
thanks, clear. (In reply to David Nind from comment #4)
Created attachment 183251 [details] [review] Bug 40107: Article requests: Some DataTables functionality is broken ...
Taking this to our productions on 25.05, let's see what they say on Monday, if issue is gone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183251|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 183459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183459&action=edit Bug 40107: Article requests: Some DataTables functionality is broken Bug 38255 standardized our DataTables using kohaTable. kohaTable returns the affected table as a jQuery object, but JavaScript on the article requests page in the staff client expects a DataTable object. This patch updates the template accordingly. To test, apply the patch and enable the ArticleRequests system preference if necessary. - Log in to the OPAC and place several article requests. - In the staff interface, go to Circulation -> Article requests. - From the list of new article requests, test the menu options under "Actions." - Changing the status of a request should make it disappear from the "New" tab and appear under the tab for the new status (or it should be removed, in case of cancel or complete). - Test the same processes under the "Pending" and "Processing" tabs. - Each time you perform one of these tasks the counters on each tab should be updated correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes JavaScript |This fixes JavaScript release notes|errors in the staff |errors in the staff |interface article requests |interface article requests |table. The tables weren't |table. The tables weren't |refreshing, and the tab |refreshing, and the tab |numbers weren't updating, |numbers weren't updating, |when selecting an action |when selecting an action |for individual or multiple |for individual or multiple |requests (such as'Set |requests (such as 'Set |request as pending'). |request as pending'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x for 25.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not sure this is needed for 24.11.x Maybe depends on Bug 38255 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 40098 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40107 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org