https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Depends on| |33484 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33484 [Bug 33484] Ability to remember user's selected table configuration and search filters for tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186140&action=edit Bug 40753: Fix DT's SaveState on the orders table We build the the orders table depending on some conditions (sysprefs or if the basket is closed/opened). DataTables cannot correctly restore the state because the number of columns stored in localStorage is different than the one we have one the table. Test plan: Open and close a basket Confirm that the table is correctly displayed (no extra columns) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Initially reported on bug 39930 comment 1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 Alla Santosh Pavan Kumar <santoshpavan.666@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff interface |Websites, Mailing Lists, | |etc CC| |santoshpavan.666@gmail.com Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the basket order release notes| |table so that when you | |close (or reopen) a basket, | |the columns shown remain | |the same as the table | |configuration. Before this | |fix, if you closed a basket | |and then reopened it, the | |table settings columns | |hidden by default were | |ignored and all the | |possible columns were | |shown. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Add an item to a basket: 1.1 Go to Acquisitions > Search vendors > Search 1.2 Click My Vendor in the results (name column) 1.3 Under the 'Baskets' column, click the link 1.4 Select 'My Basket' 1.5 Add an item to the basket 2. Note that these columns are displayed (these should match the columns displayed by default for the table configuration): . No. . Order . RRP tax exc. . Actual cost tax exc. . Budgeted cost tax exc. . Budgeted cost tax inc. . Replacement price . Qty. . Total tax exc. (USD) . GST % . GST . Fund . Estimated delivery date . Invoice . Place hold 3. Close the basket (Result = you go back to the list of baskets for the vendor). 4. Click the basket you just closed. 5. The table now shows all columns, including those hidden by default in the table configuration. 6. Apply the patch. 7. Reset everything (reset_all). 8. Repeat steps 1-4. 9. The columns now shown should be the same (and should reflect the default columns configured, and not show the hidden by default columns). Note: When saving changes to the table configuration, unless you untick 'Save configuration state on page change' and tick 'Save search state on page change', the changes are only shown after you log out and log back in again. Before the patch, the columns hidden by default in the table configuration were incorrectly shown when the basket was closed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186184|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 186239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186239&action=edit Bug 40753: Fix DT's SaveState on the orders table We build the the orders table depending on some conditions (sysprefs or if the basket is closed/opened). DataTables cannot correctly restore the state because the number of columns stored in localStorage is different than the one we have one the table. Test plan: Open and close a basket Confirm that the table is correctly displayed (no extra columns) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40982 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 24.11.x which uses : KohaTable("orders", Could you create a patch for 24.11.x ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40753 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK thanks. Not backported to 24.11.x -- You are receiving this mail because: You are watching all bug changes.