[Bug 16497] New: REST API: add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Bug ID: 16497 Summary: REST API: add routes to list libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: benjamin.rokseth@kul.oslo.kommune.no QA Contact: testopia@bugs.koha-community.org Small enhancement to REST API to add the possibility to list libraries. GET /api/v1/libraries List all libraries and branchcodes GET /api/v1/libraries/{branchcode} Get library description and branchcode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 51454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51454&action=edit Bug 16497 - REST API: add routes to list libraries Simple routes to list all or get one Library GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16652 [Bug 16652] RestfulAPI supporting services for Vufind and for xnciptoolkit drivers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51454|0 |1 is obsolete| | --- Comment #2 from Lari Taskula <larit@student.uef.fi> --- Created attachment 52905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52905&action=edit Bug 16497 - REST API: add routes to list libraries Simple routes to list all or get one Library GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Lari Taskula <larit@student.uef.fi> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit@student.uef.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #3 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 53818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53818&action=edit Bug 14793: New cataloguing plugin unimarc_field_225a_bis It is similar to unimarc_field_210c_bis, but searches in biblioitems.collectiontitle instead of biblioitems.publishercode Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52905|0 |1 is obsolete| | --- Comment #4 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Created attachment 53819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53819&action=edit Bug 16497 - REST API: add routes to list libraries Simple routes to list all or get one Library GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Lari Taskula <larit@student.uef.fi> Signed-off-by: Jiří Kozlovský <mail@jkozlovsky.cz> Works as expected. Nice work! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Jiří Kozlovský <mail@jkozlovsky.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@jkozlovsky.cz Attachment #53818|0 |1 is obsolete| | --- Comment #5 from Jiří Kozlovský <mail@jkozlovsky.cz> --- Comment on attachment 53818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53818 Bug 14793: New cataloguing plugin unimarc_field_225a_bis Sorry about this patch, my git bz did not function correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #6 from Lari Taskula <larit@student.uef.fi> --- We should figure out what to do for properties 'issuing' and 'branchprinter'. They are missing from api/v1/definitions/library.json but I would guess the reason is that Benjamin noticed kohastructure mentioning that they are not used in Koha. Perhaps they should be completely removed everywhere? I noticed this issue by running the test introduced in Bug 17032 which won't pass this definition because it sees these two "missing" properties. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53819|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 54943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54943&action=edit Bug 16497 - REST API: add routes to list libraries Simple routes to list all or get one Library GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Lari Taskula <larit@student.uef.fi> Signed-off-by: Jiří Kozlovský <mail@jkozlovsky.cz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #8 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Rebased against 16699 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think this patch must be rewritten following what has been done in bug 17428 for Cities. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #10 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Yup. Perhaps even CRUD? or is that overkill? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Benjamin Rokseth from comment #10)
Yup.
Perhaps even CRUD? or is that overkill?
That seems overkill to me, but not so hard to implement. It may make sense to be consistent and supply CRUD for such object. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18102 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18102 [Bug 18102] REST API: Add pickup_location to library's Swagger definition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18191 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18191 [Bug 18191] REST API: Add endpoint to list valid pickup locations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54943|0 |1 is obsolete| | --- Comment #12 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60801&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #13 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60802&action=edit Bug 16497: Sort definitions.json Before this file grows, we should sort it alphabetically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Lari Taskula <lari.taskula@jns.fi> --- Here is CRUD. I switched this bug report to Needs Signoff without thinking first; we should do the migration from Swagger2 to Mojolicious::Plugin::OpenAPI before pushing adding more REST API stuff. See Bug 18137. So I am going to revert the status of this bug report back to In Discussion until we proceed with the migration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60801|0 |1 is obsolete| | --- Comment #15 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 61164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61164&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60802|0 |1 is obsolete| | --- Comment #16 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 61165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61165&action=edit Bug 16497: Sort definitions.json Before this file grows, we should sort it alphabetically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 [Bug 18066] Hea - Version 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61164|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63160&action=edit [SIGNED-OFF] Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63161&action=edit [SIGNED-OFF] Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |mail@jkozlovsky.cz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Component|Web services |REST api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: add routes to |Add routes to list |list libraries |libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #19 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 66837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66837&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #20 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 66838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66838&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Bug 16497 depends on bug 18137, which changed state. Bug 18137 Summary: REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Massive unit test failures. Is the test plan incomplete, or perhaps the automerge from git isn't going right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 68746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68746&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 68747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68747&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 68748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68748&action=edit Bug 16497: (followup) New column marcorgcode added Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68746|0 |1 is obsolete| | Attachment #68747|0 |1 is obsolete| | Attachment #68748|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68838&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68838|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68839&action=edit Bug 16497: [REST] Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68840&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68841&action=edit Bug 16497: (followup) New column marcorgcode added Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please check POD coverage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 [Bug 19689] Koha Offline Circulation Firefox plugin sends entries with wrong branchcode without error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #30 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 69508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69508&action=edit Bug 16497 - Add POD in Koha/REST/V1/Library.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Assignee|mail@jkozlovsky.cz |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please: - Implement using objects.search instead of manually crafting the DBIC query - Please review the RFC I've just posted. If you add to it, add new column for your proposals. I plan to have it voted in Dec 27th's dev meeting so we can move on. https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125 [Bug 22125] branches.pickup_location should be flagged as boolean -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68840|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68841|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83913&action=edit Bug 16497: Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83914&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83915&action=edit Bug 16497: (follow-up) New column marcorgcode added Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83916&action=edit Bug 16497: Add POD in Koha/REST/V1/Library.pm Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83917&action=edit Bug 16497: (follow-up) Adapt to existing guidelines and RFC This patch makes the original implementation match what is specified on the RFC [1]. The controller is updated, and so the tests. To test: - Apply this patches: - Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => SUCCESS: Tests pass! [1] https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've just implemented what I mentioned on comment 31. The attributes got adapted to the voted RFC and the implementation now is more in line with the current practices we adopted. I'm setting it NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes to list |Add API routes for |libraries |libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud@biblibre.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #38 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83943&action=edit Bug 22125: branches.pickup_location should be flagged as boolean This trivial patch just marks the mentioned column as a boolean. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83943|0 |1 is obsolete| | --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 83943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83943 Bug 22125: branches.pickup_location should be flagged as boolean Sorry, wrong bug number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83913|0 |1 is obsolete| | Attachment #83914|0 |1 is obsolete| | Attachment #83915|0 |1 is obsolete| | Attachment #83916|0 |1 is obsolete| | Attachment #83917|0 |1 is obsolete| | --- Comment #40 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83945&action=edit Bug 16497: Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83946&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83947&action=edit Bug 16497: (follow-up) New column marcorgcode added Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83948&action=edit Bug 16497: Add POD in Koha/REST/V1/Library.pm Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 83949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83949&action=edit Bug 16497: (follow-up) Adapt to existing guidelines and RFC This patch makes the original implementation match what is specified on the RFC [1]. The controller is updated, and so the tests. To test: - Apply this patches: - Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => SUCCESS: Tests pass! [1] https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- *** Bug 18102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84198&action=edit Bug 16497: (follow-up) GET operations require staff access With the introduction of the /public namespace all other endpoints, the rest of the endpoints are restricted to privileged users. This patch makes the GET /libraries and GET /libraries/:library_id endpoints require 'catalogue' permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83945|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84588&action=edit Bug 16497: Add /api/v1/libraries CRUD for libraries via REST API. GET /api/v1/libraries - List all libraries GET /api/v1/libraries/{branchcode} - Get one Library POST /api/v1/libraries - Add new Library DELETE /api/v1/libraries/{branchcode} - Delete Library Test plan: - apply patch - run tests: t/db_dependent/api/v1/libraries.t - test API with some API tool or simple curl e.g.: curl http://host:port/api/v1/libraries curl http://host:port/api/v1/libraries/cpl Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83946|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84589&action=edit Bug 16497: Add missing field in definitions due to bug 18066 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83947|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84590&action=edit Bug 16497: (follow-up) New column marcorgcode added Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83948|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84591&action=edit Bug 16497: Add POD in Koha/REST/V1/Library.pm Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83949|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84592&action=edit Bug 16497: (follow-up) Adapt to existing guidelines and RFC This patch makes the original implementation match what is specified on the RFC [1]. The controller is updated, and so the tests. To test: - Apply this patches: - Run: $ kshell k$ prove t/db_dependent/api/v1/libraries.t => SUCCESS: Tests pass! [1] https://wiki.koha-community.org/wiki/Libraries_endpoint_RFC Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84198|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84593&action=edit Bug 16497: (follow-up) GET operations require staff access With the introduction of the /public namespace all other endpoints, the rest of the endpoints are restricted to privileged users. This patch makes the GET /libraries and GET /libraries/:library_id endpoints require 'catalogue' permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A solid implementation, well tested, passes qa scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Bug 16497 depends on bug 22125, which changed state. Bug 22125 Summary: branches.pickup_location should be flagged as boolean https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22125 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84593|0 |1 is obsolete| | --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84734&action=edit Bug 16497: (follow-up) GET operations require staff access With the introduction of the /public namespace all other endpoints, the rest of the endpoints are restricted to privileged users. This patch makes the GET /libraries and GET /libraries/:library_id endpoints require 'catalogue' permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 --- Comment #55 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84769&action=edit Bug 16497: Refactor tests using BASIC authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13895 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As per my policy of backporting new api routes to aid developers of plugins and other api reliant third party integrations I have pushed this to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #58 from Lucas Gass <lucas@bywatersolutions.com> --- 18.05.x is missing 22125 dependency, won't backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add API routes for |Add routes for library |libraries |retrieval, update and | |deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This new feature adds APIs release notes| |to list all or individual | |libraries, and to add, | |update or delete a library | |where appropriate | |permissions are held. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org