[Bug 19661] New: Funds endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Bug ID: 19661 Summary: Funds endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusburger@biblibre.com This patch adds a new route to the REST api: api/v1/acquisitions/funds/ It allows to retrieve funds informations, possibly using filters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 69243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69243&action=edit REST API: Funds Endpoint This patch adds a new route to the REST api: api/v1/acquisitions/funds/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |matthias.meusburger@biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69243|0 |1 is obsolete| | --- Comment #2 from David Bourgault <david.bourgault@inlibro.com> --- Created attachment 69833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69833&action=edit Bug 19661 - REST API: Funds Endpoint This patch adds a new route to the REST api: api/v1/acquisitions/funds/ https://bugs.koha-community.org/show_bug.cgi?id=19661 Signed-off-by: David Bourgault <david.bourgault@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Matthias, everything looks ok. Could you please describe the enpdoint here: https://wiki.koha-community.org/wiki/REST_api_RFCs (You can copy and paste from https://wiki.koha-community.org/wiki/Patrons_endpoint_RFC and adapt it). Also, would you consider implementing it using the objects.search implementation from Julian? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19826 CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should we move this out of the queue until 19826 is ready and this can be redone on top? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 [Bug 19826] Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition::Fund(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Bug 19661 depends on bug 19826, which changed state. Bug 19826 Summary: Introduce Koha::Acquisition::Budget(s) and Koha::Acquisition::Fund(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19826 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #5 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 70603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70603&action=edit Bug 19661 - Use Koha::Acquisition::Funds instead of C4::Budgets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #6 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Documentation updated here: https://wiki.koha-community.org/wiki/Acquisitions_funds_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I think this work needs a review, as some (relevant) attributes are missing on the fund definition: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/Schema/Result... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs_rfc URL| |https://wiki.koha-community | |.org/wiki/Acquisitions_fund | |s_endpoint_RFC Summary|Funds endpoint |Add routes for funds --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've added the ''needs_rfc'' keyword to this bug. The community process requires a vote on the RFC, so the dev and interested parties should take care of adding the RFC to the agenda on a dev meeting, and gather support for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #9 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 83941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83941&action=edit Bug 19661 - Add and change properties and parameters to conform to the funds RFC. Also, perform an exact search when searching on the fund owner id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Matthias Meusburger from comment #9)
Created attachment 83941 [details] [review] Bug 19661 - Add and change properties and parameters to conform to the funds RFC.
Also, perform an exact search when searching on the fund owner id.
Matthias, great work. I would like to mention I'm proposing a change here: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API basically standardize return codes and add the Location header in POST (see bug 16497 for an example). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 69833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69833 Bug 19661 - REST API: Funds Endpoint Review of attachment 69833: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19661&attachment=69833) ----------------------------------------------------------------- ::: Koha/REST/V1/Acquisitions/Funds.pm @@ +19,5 @@
+ +use Mojo::Base 'Mojolicious::Controller'; + +use C4::Budgets; +use JSON qw(to_json);
Unused import here @@ +83,5 @@
+ + return $returnfund; +} + +=head3 _to_model
Should this private routine be introduced before any corresponding write functions are added to the controller or should it be added when those routines are? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83941|0 |1 is obsolete| | --- Comment #12 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 83970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83970&action=edit Bug 19661 - Add and change properties and parameters to conform to the funds RFC. Also, perform an exact search when searching on the fund owner id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #13 from Matthias Meusburger <matthias.meusburger@biblibre.com> ---
Unused import here
Unused import removed.
Should this private routine be introduced before any corresponding write functions are added to the controller or should it be added when those routines are?
I just wanted to make future work easier :) Besides, since the RFC has already been voted, it's unlikely to change before new features are added. But any option is fine by me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_rfc | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69833|0 |1 is obsolete| | Attachment #70603|0 |1 is obsolete| | Attachment #83970|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85693&action=edit Bug 19661: REST API - Funds Endpoint This patch adds a new route to the REST api: /api/v1/acquisitions/funds/ Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85694&action=edit Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85695&action=edit Bug 19661: Add and change properties and parameters to conform to the funds RFC. Also, perform an exact search when searching on the fund owner id. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85696&action=edit Bug 19661: (follow-up) Use Basic auth in tests Test plan: prove t/db_dependent/api/v1/acquisitions_funds.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85693|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86537&action=edit Bug 19661: REST API - Funds Endpoint This patch adds a new route to the REST api: /api/v1/acquisitions/funds/ Signed-off-by: David Bourgault <david.bourgault@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85694|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86538&action=edit Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85695|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86539&action=edit Bug 19661: Add and change properties and parameters to conform to the funds RFC. Also, perform an exact search when searching on the fund owner id. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85696|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86540&action=edit Bug 19661: (follow-up) Use Basic auth in tests Test plan: prove t/db_dependent/api/v1/acquisitions_funds.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Matthias, All works well, no QA Script failures and as a new route there's no regressions.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As per my commitment to backporting new API endpoints wherever reasonable to do so... Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- cant prove t/db_dependent/api/v1/acquisitions_funds.t correctly in 18.05.x, not backporting new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes for funds |Add routes for fund | |retrieval -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add routes for fund |Add route for fund |retrieval |retrieval -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds a release notes| |REST API for working with | |acquisition funds, | |including listing, adding | |and deleting funds and fund | |users. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org