[Bug 8392] New: Memberentry is not enforcing birthdate restrictions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Priority: P5 - low Change sponsored?: --- Bug ID: 8392 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Memberentry is not enforcing birthdate restrictions Severity: enhancement Classification: Unclassified OS: All Reporter: ruth@bywatersolutions.com Hardware: All Status: NEW Version: unspecified Component: Patrons Product: Koha If dateofbirth is in BorrowerMandatoryFields, and a range of ages is set in the categories, when you enter a member, it's supposed to be checking to see if the patron's age is within that range, and complain if not. Indeed, the code seems to be trying to do just that (memberentry.pl, lines 267-276, as of 3.8.2), but it's not actually being enforced. It appears that the redefinition of @field_check for hiding some fields in the template (line 106) is the culprit. I'll have a patch shortly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 D Ruth Bavousett <ruth@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |ruth@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #1 from D Ruth Bavousett <ruth@bywatersolutions.com> --- Created attachment 10715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10715&action=edit Proposed patch To test, make sure that you have "dateofbirth" in BorrowerMandatoryFields. Then set up a category with age-range limits, and attempt to save a patron whose birthdate would be outside that range. Koha should complain, and return to the member entry screen. Change the age to within the allowable range for the category, or change the category to one where that patron's age is allowed, and the save should work. -Ruth -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 D Ruth Bavousett <ruth@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #2 from D Ruth Bavousett <ruth@bywatersolutions.com> --- This should apply to 3.8.x and Master. The change to memberentry.pl that *caused* the bug did not enter until 3.8, so it won't be needed for 3.6.x. -Ruth -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10715|0 |1 is obsolete| | --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 10718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10718&action=edit Signed-off patch I wait your sign-off on the following patch before marking this patch as signed-off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 10719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10719&action=edit Bug 8392: Avoid having an untranslatable age range -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cookie.wolfrom@liblime.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 3410 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat@biblibre.com --- Comment #6 from Adrien SAURAT <adrien.saurat@biblibre.com> --- *** Bug 8464 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10719|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10983&action=edit [SIGNED-OFF] Bug 8392: Avoid having an untranslatable age range [SIGNED-OFF] Bug 8392: Avoid having an untranslatable age range Currently, error message reports an age range in English. For example '0 to 17'. With this patch, the 'to' is not in the .pl file anymore. Ruth could you sign-off this fix? Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Humm, I think it would have been better to rename the second field_check variable. Thus the initialisation of $dateofbirthmandatory keeps close to it usage (l.~100 and l.~270). But it works. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- The patch has been pushed, but I'm wondering if there is not another problem: why should the birthdate be mandatory to deal with age limits ? Shouldn't we check AgeLimit anyway ? Shouldn't we have a rule like "check AgeLimit if there is a birthdate, otherwise, it's OK" ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #9)
Shouldn't we have a rule like "check AgeLimit if there is a birthdate, otherwise, it's OK" ?
I wondered the same thing when I was testing it, but I think it makes sense. Using BorrowerMandatoryFields acts as a de-facto system preference for choosing whether or not the age limit should be enforced. If I want to enforce the age limit on a patron category I want to enforce it on all patrons, not just patrons for whom I have entered a birth date. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #10)
(In reply to comment #9)
Shouldn't we have a rule like "check AgeLimit if there is a birthdate, otherwise, it's OK" ?
I wondered the same thing when I was testing it, but I think it makes sense. Using BorrowerMandatoryFields acts as a de-facto system preference for choosing whether or not the age limit should be enforced. If I want to enforce the age limit on a patron category I want to enforce it on all patrons, not just patrons for whom I have entered a birth date.
It's a change in the behaviour I was not aware. I think it has been introduced in 3.6. I don't see anything about that in the docs: http://manual.koha-community.org/3.8/en/patscirc.html#patcats Adding Nicole. Nicole, please read comment 9 = age limit is checked only if birthdate is a borrower mandatory field ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8392 --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- Manual updated -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org