[Bug 7509] New: Create index for items.itemcallnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Bug #: 7509 Summary: Create index for items.itemcallnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: koha.sekjal@gmail.com Create index on items itemcallnumber. It will facilitate efficient search. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff AssignedTo|gmcharlt@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2012-02-08 02:25:26 UTC --- Created attachment 7498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7498 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7498|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> 2012-02-08 17:39:07 UTC --- Created attachment 7513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7513 bug_7509: Added index on items itemcallnumber I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. I also added an atomicupdate to this patch (it was part of my testing, just thought I'd include it? Is there a preference?). Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7513|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> 2012-02-08 17:48:09 UTC --- Created attachment 7516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7516 bug_7509: Added index on items itemcallnumber I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. I also added an atomicupdate to this patch (it was part of my testing, just thought I'd include it? Is there a preference?). Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins@cpbibliography.com --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-13 01:46:16 UTC --- I don't see any reason for using atomicupdate with something this simple. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7516|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-13 01:52:01 UTC --- Created attachment 7603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7603 Bug 7509: Added index on items itemcallnumber Comment from Liz: I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 16:33:17 UTC --- Created attachment 7695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7695 Bug 7509: Added index on items itemcallnumber Comment from Liz: I couldn't get this update to fire - I found a small syntax error in the updatedatabase.pl for this, which I corrected with this patch. Functionally, all of this works as tested (once the typos were fixed), but this probably requires another sign-off. QA notes: rebased on latest master. Also added index name `itemcallnumber` to maintain consistency with all other indexes on items table. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Ian Walls <koha.sekjal@gmail.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7603|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 16:34:33 UTC --- Simple change to add a new index. Rebased to latest master and modified some syntax to be consistent with other indexes on the same table. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7509 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 10:33:56 UTC --- QA comment: the ` is a mysqlism, that is not needed. During Hackfest in Marseille, next month, we will get rid of it, so this patch would have been rejected in April. Accepted it as it's consistent with existing code, but i also had accepted the "no `" version. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org