[Bug 7532] New: opac-ics depends on Date::ICal which is largely unmaintained
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Bug #: 7532 Summary: opac-ics depends on Date::ICal which is largely unmaintained Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: robin@catalyst.net.nz QAContact: koha.sekjal@gmail.com Date::ICal is no longer really maintained, and is being dropped by Debian at least: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653301 We should probably consider replacing it with DateTime::Format::ICal. Date::ICal is only used in one place: opac/opac-ics.pl: $ grep -ri 'Date::ical' * C4/Installer/PerlDependencies.pm: 'Date::ICal' => { INSTALL.fedora7:Date::ICal opac/opac-ics.pl:use Date::ICal; opac/opac-ics.pl: my $datestart = Date::ICal->new( opac/opac-ics.pl: my $dateend = Date::ICal->new( It's likely to make it hard to deploy the packages on a Debian testing system, and also upsets my build process which uses a testing chroot. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard@myacpl.org |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2012-02-12 03:48:21 UTC --- Created attachment 7578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7578 Bug 7532 - remove dependency on Date::ICal This removes the dependency on Date::ICal (which is largely unmaintained) and replaces it with DateTime::Format::ICal which can do the same job. It also updates all the docs and installation scripts to handle this change. Note that this causes a minor behaviour change: previously the generated times were converted to UTC, now they are left "floating" (that is, have no timezone attached) and so will appear as the local time when imported into a calendar. I don't anticipate this'll cause any issues however. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2012-02-12 03:52:27 UTC --- To test: 1) As a user with some stuff issued, visit opac-ics.pl, save the calendar file. 2) Apply the patch 3) Do the same as 1) 4) Note that the files are substantively similar, accounting for the timezone difference noted in the commit message. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7578|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-02-13 00:59:52 UTC --- Created attachment 7600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7600 Bug 7532 - remove dependency on Date::ICal This removes the dependency on Date::ICal (which is largely unmaintained) and replaces it with DateTime::Format::ICal which can do the same job. It also updates all the docs and installation scripts to handle this change. Note that this causes a minor behaviour change: previously the generated times were converted to UTC, now they are left "floating" (that is, have no timezone attached) and so will appear as the local time when imported into a calendar. I don't anticipate this'll cause any issues however. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 MJ Ray (software.coop) <mjr@ttllp.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@ttllp.co.uk --- Comment #4 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2012-02-13 16:43:15 UTC --- *** Bug 7393 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <koha.sekjal@gmail.com> 2012-02-16 21:49:27 UTC --- Successfully replaces Date::ICal with DateTime::Format::ICal. Change in timezone is definitely worth noting, but shouldn't be a problem. Marking as Passed QA. Release Maintainer: does this change in opac-ics.pl functionality warrant holding off on backporting to 3.6.x and 3.4.x, or is the long-term maintainability of the dependency more important? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> 2012-02-16 22:19:09 UTC --- If it affects your decision any, applying this patch is necessary for people who want to build custom packages and use a Debian testing environment, as Date::ICal is no longer there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7532 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 10:49:43 UTC --- Introduce a new dependancy, definetly something for 3.8 and not 3.6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org