[Bug 6993] New: Incorrect data type in auth_subfield_structure
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Bug #: 6993 Summary: Incorrect data type in auth_subfield_structure Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Database AssignedTo: gmcharlt@gmail.com ReportedBy: cnighswonger@foundations.edu QAContact: koha-bugs@lists.koha-community.org kohastructure.sql makes auth_subfield_structure.linkid a tinyint(1) NOT NULL, but then authorities_normal_marc21.sql tries to insert an null string value for that field.
From kohastructure.sql:
DROP TABLE IF EXISTS `auth_subfield_structure`; CREATE TABLE `auth_subfield_structure` ( ... `linkid` tinyint(1) NOT NULL default 0, ...
From authorities_normal_marc21.sql :
INSERT INTO `auth_subfield_structure` (`authtypecode`, `tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`, `tab`, `authorised_value`, `value_builder`, `seealso`, `isurl`, `hidden`, `linkid`, `kohafield`, `frameworkcode`) VALUES ('', '000', '@', 'fixed length control field', 'fixed length control field', 0, 1, 0, NULL, 'marc21_leader_authorities.pl', NULL, 0, 0, '', '', '') ... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 14:45:12 UTC --- Bug still valid in 3.6 I think the NOT NULL is not necessary, so I propose we change to NULL -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- The files described here appear to remain unchanged from when this bug was reported but obviously there are not critical consequences since the bug has not been touched in years. Is this bug really valid? If so, is it really a critical bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- For information: MariaDB [koha]> INSERT INTO `auth_subfield_structure` (`authtypecode`, `tagfield`, `tagsubfield`, `liblibrarian`, `libopac`, `repeatable`, `mandatory`, `tab`, `authorised_value`, `value_builder`, `seealso`, `isu rl`, `hidden`, `linkid`, `kohafield`, `frameworkcode`) VALUES -> ('', '000', '@', 'fixed length control field', 'fixed length control field', 0, 1, 0, NULL, 'marc21_leader_authorities.pl', NULL, 0, 0, '', '', ''); Query OK, 1 row affected, 1 warning (0.08 sec) MariaDB [koha]> show warnings; +---------+------+----------------------------------------------------------+ | Level | Code | Message | +---------+------+----------------------------------------------------------+ | Warning | 1366 | Incorrect integer value: '' for column 'linkid' at row 1 | +---------+------+----------------------------------------------------------+ 1 row in set (0.00 sec) MariaDB [koha]> select linkid from auth_subfield_structure where tagfield='000'; +--------+ | linkid | +--------+ | 0 | +--------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |minor --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Not critical at all, considered as minor. Feel free to change it if you disagree. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org