[Bug 7118] New: Any and empty entries in pull downs for suggestion filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Bug #: 7118 Summary: Any and empty entries in pull downs for suggestion filters Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/suggestion/suggestion.pl?displayby=manag edby&branchcode=# OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Acquisitions AssignedTo: katrin.fischer@bsz-bw.de ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org The filters on the suggestion page show 'Any' and an empty entry for the filters 'Suggested by', 'Accepted by' and 'Managed by'. Both do the same. It should only be 'Any' or an empty entry, but not both. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-31 00:46:50 UTC --- Created attachment 6120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6120 Bug 7118: Remove 'any' from pull downs in acquisitions The filters on the suggestion page show 'Any' and an empty entry for the filters 'Suggested by', 'Accepted by' and 'Managed by'. Both do the same. It should only be 'Any' or an empty entry, but not both. To test: - check 'Any' is gone, but empty entry still shows - check you can still unset filters 'managed by', 'suggested by' and 'accepted by' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Failed QA --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 02:50:59 UTC --- Managed by and suggested by work, but I have no blank entry for Suggested by. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-03 07:37:45 UTC --- Hi Chris, did you mean 'suggested by'? My list looks like this: <li><label for="suggestedby"> Suggested By:</label> <select id="suggestedby" name="suggestedby"> <option value="">Any</option> <option value="0"></option> <option value="2">Katrin, Fischer</option> So my blank entry came from the 0 value, but there is indeed no value="" line. Investigating... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-03 07:50:36 UTC --- Ok, I see now what's going on here: The empty line shows when you have at least one suggestion, where the value for the column is null. For 'suggested by' this should never happen, so there is no empty line. Not sure how I managed to do that - might be a bug or from testing something else. The 'Any' lines are actually needed. So the solution to the confusing list is invalid. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6120|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P1 Patch Status|Failed QA |--- --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-03 07:54:14 UTC --- Any and the empty lines have both value="". So both settings will search for all entries and there is currently no way to search for unmanaged or unaccepted entries. Leaving the bug open. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer@bsz-bw.de |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7118 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good now, please reopen if I am wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org