[Bug 16127] New: Add discharge menu item to patron toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Bug ID: 16127 Summary: Add discharge menu item to patron toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The patron discharge feature added a "Discharge" tab in the left-hand sidebar menu. I think if we follow views vs. actions guideline (https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions), the link in the sidebar should say "Discharges" (as in view the patron's list of discharges) and there should be menu item in the toolbar (members-toolbar.inc) for the action of discharging the patron. I think this should be added to the "More" drop-down menu. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51927&action=edit Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51927|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51932&action=edit Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51932|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52285&action=edit Bug 16127 - Add discharge menu item to patron toolbar This patch changes the "Discharge" menu in the patron sidebar to read "Discharges," and adds a "Discharge" menu item to the patron toolbar. This adds some redunancy, but fits with the pattern of including "views" in the sidebar and "actions" in the menu. The discharge feature can be thought of either way. To test you must have the 'useDischarge' system preference enabled. - View the detail page for any patron. - Confirm that the sidebar menu reads "Discharges." - Confirm that the "More" menu contains a "Discharge" link which works correctly. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Depends on| |8007 CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.9 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007 [Bug 8007] Discharge management -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org