https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 159661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159661&action=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159661|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 159677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159677&action=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- How should this interact with Bug 30230 ? Just do the following substitution? (CAN_user_borrowers_edit_borrowers) ↓↓ (CAN_user_borrowers_edit_borrowers) || (CAN_user_borrowers_list_borrowers) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159677|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 160671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160671&action=edit Bug 35517: Choose correct default header search tab according to permissions This patch adds some additional template logic to the header search form for the staff interface home page so that users with different permissions will see the correct tab in the header search form. To test, apply the patch and view the staff interface home page using a user with different permissions: - 'catalogue' and 'circulate' - Header should show circulation search - 'catalogue' and 'borrowers' - Header should show patron search - 'catalogue' only - Header should show catalog search Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #4)

(In reply to Victor Grousset/tuxayo from comment #3)

...

(CAN_user_borrowers_edit_borrowers) || (CAN_user_borrowers_list_borrowers)

That looks correct to me. In either case the user should have access to the patron search tab.

This patch has not been pushed yet, I'll keep it in mind! (Waiting for a not hard follow-up... ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35517 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #7)

This patch has not been pushed yet, I'll keep it in mind! (Waiting for a not hard follow-up... )

It wasn't sure at the time of my 1st message here which one would be merged first. But when I QAed this one, I left a comment on bug 30230 to say that it needs a change. -- You are receiving this mail because: You are watching all bug changes.