http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi Fridolyn. It works well, so I sign off. But I have found SearchSubscriptions is used 2 times in code : ./serials/serials-search.pl ./acqui/newordersubscription.pl So I think you need to make changes too to the template used by newordersubscription.pl (I have checked : there is always one note on this page). Maybe in an other patch? Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21100|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21598&action=edit [SIGNED-OFF] Bug 10689 - public note does not appear in subscriptions search In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). Test plan : - Edit a subscription - Add public and internal notes. For example : "too busy" and "on holiday" - Perform a subscription search that returns this subscription => "Notes" column contains both notes. For example : "too busy (on holiday)" - Test with only public note - Test with only internal note ==== Works as described. Signed-off-by:Mathieu Saby <mathieu.saby@uhb.fr> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Adding a sign -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21598|0 |1 is obsolete| | Attachment #21599|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21602&action=edit [PASSED QA] Bug 10689 - public note does not appear in subscriptions search In a serials module, when searching subscriptions, the results table as a "Notes" column. In TT code, you see that it tries to display public note "subscription.notes" and internal note "subscription.internalnotes". Internal note is well displayed but not public note. You can see the 2 notes in serial details in summary tab. The problem commes from the SQL query. A join is perform on subscription and biblio, both containing a "notes" column. This patch solves the problem by using a alias in query for both columns (biblio.notes is acutally not used in template but could be). Test plan : - Edit a subscription - Add public and internal notes. For example : "too busy" and "on holiday" - Perform a subscription search that returns this subscription => "Notes" column contains both notes. For example : "too busy (on holiday)" - Test with only public note - Test with only internal note ==== Works as described. Signed-off-by:Mathieu Saby <mathieu.saby@uhb.fr> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Adding a sign Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Works as described, fixes a bug as the templates show that the intention was to display both notes in the column. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that adds a regression test. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.