[Bug 10430] New: status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Bug ID: 10430 Summary: status filter not working in serial claims when translated Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com CC: colin.campbell@ptfs-europe.com Whis a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". We could change translation but it would be better if filter did not work on status name. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- [With] a translated intranet. Sorry :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10429 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I also created Bug 10429 for branch filter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 18748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18748&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I update to major importance because many libraries have reported this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Should we be using a class, and then selecting on a class when we could/should be using and id? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I used a class because there are several cells to identify ; an id must be unique. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I set back to Need Signoff. The QA validation will say if using a class is correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18748|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20197&action=edit Bug 10430 - status filter not working in serial claims when translated With a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". This patch changed javascript filter to work on a status code instead of status name. The new classes may be used to change CSS depending on status. Test plan : - Use a translated intranet (ie fr-FR) - Go to serials claim of a vendor with issues of multiple status - Check that status filter does its work Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- You do realise I am on the QA team right? However I have signed off, someone elses problem now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Chris Cormack from comment #9)
You do realise I am on the QA team right? Yes sorry, of course I know it, I surly had an amnesia moment.
In fact I do not understand how it could use an id. Could you give a piece of code ? Looking at Bug 10429 it appears there are several bugs on those filters. They all could be solved by using a JQuery Datatable for claims table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch works nicely and the classes are correct, as every status can show up multiple times in this table. But I am a bit confused about "Arrived" and "Stopped" showing up in this list. I checked the code and I think the pull down of filters should only have: Missing, Expected, Late, and Claimed. ----- =head2 GetLateOrMissingIssues ... AND (serial.STATUS = 4 OR ((planneddate < now() AND serial.STATUS =1) OR serial.STATUS = 3 OR serial.STATUS = 7))
From the reports help: 1 = Expected 2 = Arrived 3 = Late 4 = Missing 5 = Not Available 6 = Delete 7 = Claimed 8 = Stopped
This patch only adds 'Stopped', the other status have been there before. I think this can be fixed in a follow up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20197|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20588&action=edit [PASSED QA] Bug 10430 - status filter not working in serial claims when translated With a translated intranet (ie fr-FR) the status filter does not work for "Late" status. It is because status in combobox filter is translated "Retard" and status in table is translated "En retard". This patch changed javascript filter to work on a status code instead of status name. The new classes may be used to change CSS depending on status. Test plan : - Use a translated intranet (ie fr-FR) - Go to serials claim of a vendor with issues of multiple status - Check that status filter does its work Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch passes all tests and QA script. The status filter should probably be changed to only allow filtering on status that can appear on the page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #13 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 20704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20704&action=edit Bug 10430 - arrived and stopped status are not possible in serial claim Follow up to remove arrived and stopped status, as asked. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 --- Comment #14 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
I think this can be fixed in a follow up.
I added follow-up but did not change the bug status. I let you manage it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org