[Bug 12147] New: Column width for action links on invoices too small
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Bug ID: 12147 Summary: Column width for action links on invoices too small Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Created attachment 27675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27675&action=edit Invoices table In the table of invoices the last column is not wide enough for the links, that causes each line to be 3 lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #1 from Marc Véron <veron@veron.ch> --- It really looks ugly... My first idea was to put non breakting spaces around te slashes in lines 144 and 151 in invoices.tt, but this does not work out because of the formatting (indenting) with spaces. One would have to putt all of the if-else-logic on one line, and that is no good idea. Looking at the HTML code I see tat all column headers get a hardcoded style "width" with values between 19.2 and 126.2px - exept of the last one with the action links. But I do not see where this is done? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 27762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27762&action=edit Bug 12147 - Column width for action links on invoices too small To test: Got to Home > Acquisitions > Invoices and verify that the last column of invoices table displays properly and, in HTML code, has a property like "style="width: 134.2px;" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27949&action=edit Bug 12147 [Alternate] Column width for action links on invoices too small This alternative patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed <input> and an improperly closed <option>. To test, view the invoices page and confirm that the "Actions" menu button works corectly. Test the functionality of each menu options: Details, Close, Reopen, and Delete. Confirm that sorting by billing date still works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 27956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27956&action=edit [Signed-off] Bug 12147 [Alternate] Column width for action links on invoices too small This alternative patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed <input> and an improperly closed <option>. To test, view the invoices page and confirm that the "Actions" menu button works corectly. Test the functionality of each menu options: Details, Close, Reopen, and Delete. Confirm that sorting by billing date still works correctly. Much nicer user interface. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- [% FOREACH budget IN budgets_loop %] - <option value="[% budget.budget_id %]"> - [% budget.budget_name %] + <option value="[% invoice.invoiceid %]">[% budget.budget_name %] Is this correct? invoice and budget.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 27956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27956 [Signed-off] Bug 12147 [Alternate] Column width for action links on invoices too small Review of attachment 27956: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12147&attachment=27956) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt @@ +183,4 @@
<select id="merge_shipment_budgetid" name="shipment_budget_id"> <option value="">No fund</option> [% FOREACH budget IN budgets_loop %] + <option value="[% invoice.invoiceid %]">[% budget.budget_name %]
Owen, could you confirm this change is intended? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27956|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 28162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28162&action=edit [Signed-off] Bug 12147 [Alternate] Column width for action links on invoices too small Bug 12147 [Alternate] Column width for action links on invoices too small This alternative patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed <input> and an improperly closed <option>. To test, view the invoices page and confirm that the "Actions" menu button works corectly. Test the functionality of each menu options: Details, Close, Reopen, and Delete. Confirm that sorting by billing date still works correctly. Much nicer user interface. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
Owen, could you confirm this change is intended?
It was not. I have attached a corrected patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28167&action=edit Bug 12147: Column width for action links on invoices too small This alternative patch groups "action" links into a menu as was done with Bug 11763. This patch also converts the date column sorting configuration to use header class instead of an index. This patch also corrects a couple of HTML markup errors: An improperly-closed <input> and an improperly closed <option>. To test, view the invoices page and confirm that the "Actions" menu button works corectly. Test the functionality of each menu options: Details, Close, Reopen, and Delete. Confirm that sorting by billing date still works correctly. Much nicer user interface. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- The patch didn't applied, I got "fatal: cannot convert from UTF-8utf-8 to UTF-8". I applied it manually and recreated the path. Note there is no confirmation needed on deleting an invoice. Which is quite dangerous I think. This behavior existed before this patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master and 3.16.x. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12646 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org