[Bug 11798] New: Problems with column sorting and row visibility in invoices table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Bug ID: 11798 Summary: Problems with column sorting and row visibility in invoices table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: abl@biblos.pk.edu.pl QA Contact: testopia@bugs.koha-community.org There are some problems with column sorting and row visibility in invoices table. Symptoms: 1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all). 2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars. (I'm not quite sure it's an error, perhaps it was intended to work like that = a feature, not a bug)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 --- Comment #1 from Jacek Ablewicz <ablewicz@gmail.com> --- Created attachment 25479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25479&action=edit Bug 11798 - Problems with column sorting and row visibility in invoices table 1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all). 2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars. This patch fixes sorting for "Billing date" & "Vendor" columns in invoices table and restores the ability to see all table rows/search results (not just "top ten"). Test plan (you'll need to have 11+ invoices with various billing dates entered in the system): 1) apply patch, 2) view the Acquisitions invoices page (acqui/invoices.pl), do some search (= as broad search as possible) and confirm that "Billing date" and "Vendor" columns now do sort correctly, 3) in situations when there are more then 10 search results, they should all be visible in the invoices table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |abl@biblos.pk.edu.pl Patch complexity|--- |Trivial patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10794 Assignee|koha-bugs@lists.koha-commun |abl@biblos.pk.edu.pl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25479|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 25602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25602&action=edit [SIGNED OFF] Bug 11798 - Problems with column sorting and row visibility in invoices table 1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all). 2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars. This patch fixes sorting for "Billing date" & "Vendor" columns in invoices table and restores the ability to see all table rows/search results (not just "top ten"). Test plan (you'll need to have 11+ invoices with various billing dates entered in the system): 1) apply patch, 2) view the Acquisitions invoices page (acqui/invoices.pl), do some search (= as broad search as possible) and confirm that "Billing date" and "Vendor" columns now do sort correctly, 3) in situations when there are more then 10 search results, they should all be visible in the invoices table. NOTE: Generating invoices is a painfully convoluted mess. All my "Billing date" entries were blank, so was not able to confirm Billing date issues. However, Vendor sorting issues, seeing more than 10, and in my bizarre initial case the non-visible checkboxes were all fixed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25602|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25611&action=edit Bug 11798 - Problems with column sorting and row visibility in invoices table 1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all). 2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars. This patch fixes sorting for "Billing date" & "Vendor" columns in invoices table and restores the ability to see all table rows/search results (not just "top ten"). Test plan (you'll need to have 11+ invoices with various billing dates entered in the system): 1) apply patch, 2) view the Acquisitions invoices page (acqui/invoices.pl), do some search (= as broad search as possible) and confirm that "Billing date" and "Vendor" columns now do sort correctly, 3) in situations when there are more then 10 search results, they should all be visible in the invoices table. NOTE: Generating invoices is a painfully convoluted mess. All my "Billing date" entries were blank, so was not able to confirm Billing date issues. However, Vendor sorting issues, seeing more than 10, and in my bizarre initial case the non-visible checkboxes were all fixed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jacek! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Suzanne Fayle <sfayle@roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle@roseman.edu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11798 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12646 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org