[Bug 42761] New: Error when switching to Advanced editor after importing Z39.50
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42761 Bug ID: 42761 Summary: Error when switching to Advanced editor after importing Z39.50 Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: sam.young@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When we import using Z39.50 it opens in the basic editor. When we try to switch to advanced a javascript alert pops up saying "The record cannot be transferred to the advanced editor. Continue?". If we click on continue the record is actually transferred to the advanced editor. This happens ONLY when you click on the import from the z39.50 screen. Looking at the code it is happening in addbiblio.tt on line 41-43 where var breedingid = [% breedingid || "null" | html %]; if ( !confirm( breedingid ? _("This record cannot be transferred to the advanced editor. Continue?") : _("Any changes will not be saved. Continue?") ) ) return false; the breedingid exists here BUT will still transfer to the editor can we get this logic fixed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42761 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- I only see one set of steps where that could occur, and that's for a very liberal definition of "will still transfer to the editor." If you go to Cataloging - New from Z39.50/SRU, or if you perform a search in the catalog and then do Z39.50/SRU search, after you import a record you have biblionumber=0&breedingid=99 and so nothing will be transfered, because you hit the else from if ( biblionumber ) and just load '/cgi-bin/koha/cataloguing/editor.pl' and get a blank record. However, if you open a record in the basic editor (either intentionally or by it being a Fast Add record that forces you there), then Replace record via Z39.50/SRU search, you have biblionumber=441&breedingid=100 and if you say Yes to continue to the advanced editor, you will load the biblionumber record, not the breedingid record. Certainly there could be a third case for if ( biblionumber && breedingid ) with a prompt explaining that you can only transfer the biblio at the time you loaded it, throwing away the record you've replaced it with, but wouldn't it be simpler just to say "Curse you for loading this Fast Add record in the basic editor, I shall immediately switch to the advanced editor before I replace it" and skip having to replace it twice, once in the basic editor and again in the advanced? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42761 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Z39.50 / SRU / OpenSearch |Cataloging |Servers | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org