[Bug 35292] New: Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckOut system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Bug ID: 35292 Summary: Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckOut system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com For parity and more workflow options, adding the same option to the new status that updates not for loan on checkout should also have the ability to limit by item type like Bug 25560 did for check in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175201&action=edit Bug 35292: Database changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175202&action=edit Bug 35292: Template changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175203&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. Test plan: Do not apply patch: 1 - Set UpdateNotForLoanStatusOnCheckin to 2: 0 2 - Set UpdateNotForLoanStatusOnCheckout to _ALL_: 0: 2 3 - Check out a book -> Its notforloan status is set to 2 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 notification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Removing status needs signoff, need to update the test suite -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30403 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25560 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175201|0 |1 is obsolete| | Attachment #175202|0 |1 is obsolete| | Attachment #175203|0 |1 is obsolete| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175316&action=edit Bug 35292: Database changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175317&action=edit Bug 35292: Template changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175318&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. Test plan: Do not apply patch: 1 - Set UpdateNotForLoanStatusOnCheckin to 2: 0 2 - Set UpdateNotForLoanStatusOnCheckout to _ALL_: 0: 2 3 - Check out a book -> Its notforloan status is set to 2 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 notification -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175319&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175320&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175321&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 175322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175322&action=edit Bug 35292: Move tests for UpdateNotForLoanStatusOnCheckin in a subtest Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com --- Comment #12 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, I just tried this test but it quickly failed (even before applying the patch) Steps 1 to 2: ok Step 3 : ok in UNIMARC (but I had to erase the space which stands just before the 2 in UpdateNotForLoanStatusOnCheckout) but not ok in MARC21, the status is not set to 2 Step 4 : in UNIMARC, the status is not set to 0 (I didn't try in MARC21 because it failed before) is there anything I missed ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Stephanie Etallaz <stephanie.etallaz@univ-cotedazur.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |stephanie.etallaz@univ-cote | |dazur.fr --- Comment #13 from Stephanie Etallaz <stephanie.etallaz@univ-cotedazur.fr> --- Same problem as Emmanuel, open a ticket "Bug 39386" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hi, Thanks for your attention to this bug, There was an issue in the test plan, hence it can't work. You need to invert the sysprefs CORRECTED 1&2: 1 - Set UpdateNotForLoanStatusOnCheckout to 2: 0 2 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 0: 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #15 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- My precedent comment is still confunsing with both sysprefs, so I edit it :p Hi, Thanks for your attention to this bug, There was an issue in the test plan, hence it can't work. You need to invert the sysprefs CORRECTED 1&2: 1 - Set UpdateNotForLoanStatusOnCheckout to 0: 2 2 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 To explain: UpdateNotForLoanStatusOnCheckout use the old syntax, which we want to update (the purpose of this patch). It should set the notforloanstatus to anything UpdateNotForLoanStatusOnCheckin uses the new syntax, it should, for our tests, set the notforloanstatus to something which does not prevent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Better to fix the test plan in the patch. When training people to test patches, the least overwhelming strategy I found for now to avoid drowning in tons of comments with many old versions of the test plan, is to go to "Attachments" here in the ticket. And click on the date to jump directly to the current patches. But it will miss messages like the above. Which might get buried in more comment so not only beginners risk not getting the issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175316|0 |1 is obsolete| | --- Comment #17 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179818&action=edit Bug 35292: Database changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175317|0 |1 is obsolete| | --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179819&action=edit Bug 35292: Template changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175318|0 |1 is obsolete| | --- Comment #19 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179820&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. Test plan: Do not apply patch: 1 - Set UpdateNotForLoanStatusOnCheckout to 0: 2 2 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 3 - Check out a book -> Its notforloan status is set to 2 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 notification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175319|0 |1 is obsolete| | --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179821&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175320|0 |1 is obsolete| | --- Comment #21 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179822&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175321|0 |1 is obsolete| | --- Comment #22 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179823&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175322|0 |1 is obsolete| | --- Comment #23 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179824&action=edit Bug 35292: Move tests for UpdateNotForLoanStatusOnCheckin in a subtest Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #24 from Emmanuel Bétemps <e.betemps@gmail.com> --- A problem occured when I tried to apply the patch error: sha1 information is lacking or useless (installer/data/mysql/mandatory/sysprefs.sql). error: could not build fake ancestor Patch failed at 0001 Bug 35292: Database changes [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-35292-Database-changes-uulcmt0i.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179818|0 |1 is obsolete| | --- Comment #25 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180101&action=edit Bug 35292: Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179819|0 |1 is obsolete| | --- Comment #26 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180102&action=edit Bug 35292: Template changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179820|0 |1 is obsolete| | --- Comment #27 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180103&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. Test plan: Do not apply patch: 1 - Set UpdateNotForLoanStatusOnCheckout to 0: 2 2 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 3 - Check out a book -> Its notforloan status is set to 2 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 0: 2 BK: 0: 3 CR: 0: 4 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 notification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179821|0 |1 is obsolete| | --- Comment #28 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180104&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179822|0 |1 is obsolete| | --- Comment #29 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180105&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179823|0 |1 is obsolete| | --- Comment #30 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180106&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180102|0 |1 is obsolete| | Attachment #180103|0 |1 is obsolete| | Attachment #180104|0 |1 is obsolete| | Attachment #180105|0 |1 is obsolete| | Attachment #180106|0 |1 is obsolete| | --- Comment #31 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180181&action=edit Bug 35292: Database changes bsoletes: 180101 - Bug 35292: Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #32 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180182&action=edit Bug 35292: Template changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #33 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180183&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. Test plan: Do not apply patch: 1 - Set UpdateNotForLoanStatusOnCheckout to 0: 2 2 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 3 - Check out a book -> Its notforloan status is set to 2 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 0: 2 BK: 0: 3 CR: 0: 4 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 notification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #34 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180184&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #35 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180185&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #36 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180186&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179824|0 |1 is obsolete| | --- Comment #37 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180210&action=edit Bug 35292: Move tests for UpdateNotForLoanStatusOnCheckin in a subtest Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180181|0 |1 is obsolete| | --- Comment #38 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180212&action=edit Bug 35292: Database changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180182|0 |1 is obsolete| | --- Comment #39 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180213&action=edit Bug 35292: Template changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180183|0 |1 is obsolete| | --- Comment #40 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180214&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. Test plan: Do not apply patch: 1 - Set UpdateNotForLoanStatusOnCheckout to 0: 2 2 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 3 - Check out a book -> Its notforloan status is set to 2 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 notification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180184|0 |1 is obsolete| | --- Comment #41 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180215&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180185|0 |1 is obsolete| | --- Comment #42 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180216&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180186|0 |1 is obsolete| | --- Comment #43 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180217&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180210|0 |1 is obsolete| | --- Comment #44 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180218&action=edit Bug 35292: Move tests for UpdateNotForLoanStatusOnCheckin in a subtest Note: These patches have been split for sake of understandability for review but they should probably be squashe -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180212|0 |1 is obsolete| | --- Comment #45 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180632&action=edit Bug 35292: Database changes Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180213|0 |1 is obsolete| | --- Comment #46 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180633&action=edit Bug 35292: Template changes Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180214|0 |1 is obsolete| | --- Comment #47 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180634&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. 1 - Set UpdateNotForLoanStatusOnCheckin to 2: 0 2 - Set UpdateNotForLoanStatusOnCheckout to _ALL_: 0: 2 3 - Check out a book -> Its notforloan status is set to 2 3b - Check you have 2, 3 and 4 in notforloan, if not add those values with any description 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH and update database 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 0: 2 BK: 0: 3 CR: 0: 4 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a notification 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180215|0 |1 is obsolete| | --- Comment #48 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180635&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180216|0 |1 is obsolete| | --- Comment #49 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180636&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180217|0 |1 is obsolete| | --- Comment #50 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180637&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180218|0 |1 is obsolete| | --- Comment #51 from Emmanuel Bétemps <e.betemps@gmail.com> --- Created attachment 180638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180638&action=edit Bug 35292: Move tests for UpdateNotForLoanStatusOnCheckin in a subtest Note: These patches have been split for sake of understandability for review but they should probably be squashe Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #52 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 180632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180632 Bug 35292: Database changes
From 318c2ddedf9bacb00bebf1e8465a8c1df40d84fe Mon Sep 17 00:00:00 2001 From: Baptiste <baptiste.wojtkowski@biblibre.com> Date: Wed, 4 Dec 2024 17:22:06 +0100 Subject: [PATCH] Bug 35292: Database changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> --- ...pdateNotForLoanStatusOnCheckOut_syspref.pl | 35 +++++++++++++++++++ installer/data/mysql/mandatory/sysprefs.sql | 2 +- 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100755 installer/data/mysql/atomicupdate/bug_35292-amend_UpdateNotForLoanStatusOnCheckOut_syspref.pl
diff --git a/installer/data/mysql/atomicupdate/bug_35292-amend_UpdateNotForLoanStatusOnCheckOut_syspref.pl b/installer/data/mysql/atomicupdate/bug_35292-amend_UpdateNotForLoanStatusOnCheckOut_syspref.pl new file mode 100755 index 0000000000..ad866723d6 --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_35292-amend_UpdateNotForLoanStatusOnCheckOut_syspref.pl @@ -0,0 +1,35 @@ +use Modern::Perl; + +return { + bug_number => "35292", + description => "Migrating existing UpdateNotForLoanStatusOnCheckout rules to new format", + up => sub { + my ($args) = @_; + my ( $dbh, $out ) = @$args{qw(dbh out)}; + + my ($UpdateNotForLoanStatusOnCheckout) = $dbh->selectrow_array( + q| + SELECT value FROM systempreferences WHERE variable='UpdateNotForLoanStatusOnCheckout' + | + ); + + my ( $new_rules, $updated_rules ); + if ( $UpdateNotForLoanStatusOnCheckout && $UpdateNotForLoanStatusOnCheckout !~ /[0-9a-zA-Z_]:\r/ ) { + + # Split and re-format the existing rules under a single _ALL_ special term to affect all itemtypes + my @rules = split /\r/, $UpdateNotForLoanStatusOnCheckout; + foreach my $rule (@rules) { + $rule =~ s/^\s+|\s+$|\r|\n//g; + $new_rules .= ' ' . $rule . "\r"; + } + $updated_rules .= "_ALL_:\r$new_rules\r"; + $dbh->do( + qq{ + UPDATE systempreferences + SET value = '$updated_rules', explanation = "This is a list of item types and value pairs.\nExamples:\n_ALL_:\n -1: 0\n\nCR:\n 1: 0\n\nWhen an item is checked out, if its item type matches CR then when the value on the left (1) matches the items not for loan value it will be updated to the value on the right.\n\nThe special term _ALL_ is used on the left side of the colon (:) to affect all item types. This does not override all other rules\n\nEach item type needs to be defined on a separate line on the left side of the colon (:).\nEach pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space." + WHERE variable = 'UpdateNotForLoanStatusOnCheckout' + } + ); + } + }, +}; diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql index 2bf9d0b648..a765ad786b 100644 --- a/installer/data/mysql/mandatory/sysprefs.sql +++ b/installer/data/mysql/mandatory/sysprefs.sql @@ -829,7 +829,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` ('UpdateItemLostStatusWhenWriteoff', '0', NULL, 'Allows the status of lost items to be automatically changed to lost and paid for when written off', 'Integer'), ('UpdateItemWhenLostFromHoldList','',NULL,'This is a list of values to update an item when it is marked as lost from the holds to pull screen','Free'), ('UpdateNotForLoanStatusOnCheckin', '', 'NULL', 'This is a list of item types and value pairs.\nExamples:\n_ALL_:\n -1: 0\n\nCR:\n 1: 0\n\nWhen an item is checked in, if its item type matches CR then when the value on the left (1) matches the items not for loan value it will be updated to the value on the right.\n\nThe special term _ALL_ is used on the left side of the colon (:) to affect all item types. This does not override all other rules\n\nEach item type needs to be defined on a separate line on the left side of the colon (:).\nEach pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space.', 'Free'), -('UpdateNotForLoanStatusOnCheckout', '', 'NULL', 'This is a list of value pairs. When an item is checked out, if the not for loan value on the left matches the items not for loan value it will be updated to the right-hand value. E.g. ''-1: 0'' will cause an item that was set to ''Ordered'' to now be available for loan. Each pair of values should be on a separate line.', 'Free'), +('UpdateNotForLoanStatusOnCheckout', '', 'NULL', 'This is a list of item types and value pairs.\nExamples:\n_ALL_:\n -1: 0\n\nCR:\n 1: 0\n\nWhen an item is checked out, if its item type matches CR then when the value on the left (1) matches the items not for loan value it will be updated to the value on the right.\n\nThe special term _ALL_ is used on the left side of the colon (:) to affect all item types. This does not override all other rules\n\nEach item type needs to be defined on a separate line on the left side of the colon (:).\nEach pair of not for loan values, for that item type, should be listed on separate lines below the item type, each indented by a leading space.', 'Free'), ('UpdateTotalIssuesOnCirc','0',NULL,'Whether to update the totalissues field in the biblio on each circ.','YesNo'), ('UploadPurgeTemporaryFilesDays','',NULL,'If not empty, number of days used when automatically deleting temporary uploads','integer'), ('uppercasesurnames','0',NULL,'If ON, surnames are converted to upper case in patron entry form','YesNo'), -- 2.39.5
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #53 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I tried to do a one character fix via the bugzilla web interface ("edit attachmement as comment") and it didn't work ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (1) matches the items' vs (1) matches the items In dbrev vs new db -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 --- Comment #55 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 180646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180646&action=edit Bug 35292: (QA follow-up) To squash with the main patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #56 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- It looks like the QA tool has a complaint about tidiness: [FAIL] C4/Circulation.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl C4/Circulation.pm` It's very trivial, looks like you just need to remove an extra line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180632|0 |1 is obsolete| | --- Comment #57 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185729&action=edit Bug 35292: Database changes Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180633|0 |1 is obsolete| | --- Comment #58 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185730&action=edit Bug 35292: Template changes Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180634|0 |1 is obsolete| | --- Comment #59 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185731&action=edit Bug 35292: Have UpdateNotForLoanStatusOnCheckOut and UpdateNotForLoanStatusOnCheckIn use the same function Both sysprefs use the same codebase. Hence the recent upgrades for UpdateNotForLoanStatusOnCheckOut were not applyied to checkout. In this patch, we refacto code in order to have them both use the same function. 1 - Set UpdateNotForLoanStatusOnCheckin to 2: 0 2 - Set UpdateNotForLoanStatusOnCheckout to _ALL_: 0: 2 3 - Check out a book -> Its notforloan status is set to 2 3b - Check you have 2, 3 and 4 in notforloan, if not add those values with any description 4 - Check in the book -> Its notforloan status is set to 0, you get a notification 6 - APPLY PATCH and update database 7 - Set UpdateNotForLoanStatusOnCheckin to _ALL_: 2: 0 BK: 3: 0 CR: 4: 0 8 - Set UpdateNotForLoanStatusOnCheckOut to _ALL_: 0: 2 BK: 0: 3 CR: 0: 4 8 - Check out a book -> Its notforloan status is set to 3 9 - Check in the book -> Its notforloan status is set to 0, you get a notification 10 - Check out a continuing resource -> Its notforloan status is set to 4 11 - Check in a continuing resource -> Its notforloan status is set to 0 11 - Check out another type of resource -> Its notforloan status is set to 2 12 - Check in the document -> Its notforloan status is set to 0 Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180635|0 |1 is obsolete| | --- Comment #60 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185732&action=edit Bug 35292: Move tests of UpdateNotforloan together Note: These patches have been split for sake of understandability for review but they should probably be squashed Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180636|0 |1 is obsolete| | --- Comment #61 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185733&action=edit Bug 35292: Update tests for UpdateNotForloanStatusOnCheckout Note: These patches have been split for sake of understandability for review but they should probably be squashe Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180637|0 |1 is obsolete| | --- Comment #62 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185734&action=edit Bug 35292: Add tests for _updateNotForLoanFromYaml Note: These patches have been split for sake of understandability for review but they should probably be squashe Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180638|0 |1 is obsolete| | --- Comment #63 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185735&action=edit Bug 35292: Move tests for UpdateNotForLoanStatusOnCheckin in a subtest Note: These patches have been split for sake of understandability for review but they should probably be squashe Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180646|0 |1 is obsolete| | --- Comment #64 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185736&action=edit Bug 35292: (QA follow-up) To squash with the main patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org