https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 98782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98782&action=edit Attachment to Bug 24648 - Contextualization of past tense "Created" Bug 24648: Contextualization of past tense 'Created' In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. This patch adds contextualization for the "Created" verb The following files have been modified: booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion To test, apply the patch and visit all those pages in English to make sure there is no change. 1) Go to Acquisitions 2) Search for vendors 3) On the vendors result pages, check the 'Created by' column heading of the baskets 4) Click on one of the baskets, check the basket info at the top, it should say 'Created by:' 5) Click Transfer on one of the orders 6) Search for and choose a vendor 7) In the list of that vendor's basket, it should say 'Created by' 8) Go to a patron's account 9) Add a manual restriction in the Restrictions tab at the bottom 10) In the restriction info, it should say 'Created' 11) Click on the Purchase suggestions tab on the left 12) Add a new suggestion 13) In the Suggestion management section, it should say 'Created by:' 14) Submit the suggestion 15) From the list of suggestions, click on the title 16) In Suggestion management, it should say 'Created by:' Next, install a new language (fr-CA used as example) 1) translate create fr-CA 2) open fr-CA-messages.po and add a translation for 'basket created by', 'patron restriction created on' and 'suggestion created by' (it doesn't have to be real, just write something different for each) 3) translate install fr-CA 4) in the system preferences, enable the french language in 'language' 5) change interface language to french Redo the tests above to make sure the word you put in the translation for the basket is in the places where 'Created by' refers to a basket, that the translation for the patron restriction is where it should be and that the translation you put in for the purchase suggestion is in the places where 'Created by' refers to a purchase suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98782|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99025&action=edit Bug 24648: Contextualization of past tense 'Created' In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. This patch adds contextualization for the "Created" verb The following files have been modified: booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion To test, apply the patch and visit all those pages in English to make sure there is no change. 1) Go to Acquisitions 2) Search for vendors 3) On the vendors result pages, check the 'Created by' column heading of the baskets 4) Click on one of the baskets, check the basket info at the top, it should say 'Created by:' 5) Click Transfer on one of the orders 6) Search for and choose a vendor 7) In the list of that vendor's basket, it should say 'Created by' 8) Go to a patron's account 9) Add a manual restriction in the Restrictions tab at the bottom 10) In the restriction info, it should say 'Created' 11) Click on the Purchase suggestions tab on the left 12) Add a new suggestion 13) In the Suggestion management section, it should say 'Created by:' 14) Submit the suggestion 15) From the list of suggestions, click on the title 16) In Suggestion management, it should say 'Created by:' Next, install a new language (fr-CA used as example) 1) translate create fr-CA 2) open fr-CA-messages.po and add a translation for 'basket created by', 'patron restriction created on' and 'suggestion created by' (it doesn't have to be real, just write something different for each) 3) translate install fr-CA 4) in the system preferences, enable the french language in 'language' 5) change interface language to french Redo the tests above to make sure the word you put in the translation for the basket is in the places where 'Created by' refers to a basket, that the translation for the patron restriction is where it should be and that the translation you put in for the purchase suggestion is in the places where 'Created by' refers to a purchase suggestion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen, I added your sign-off line manually. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99025|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99126&action=edit Bug 24648: Contextualization of past tense 'Created' In French, everything has one of the binary genders (male or female), and it affects the past tense verb agreements. This patch adds contextualization for the "Created" verb The following files have been modified: booksellers.tt - refers to a basket basket.tt - refers to a basket transferorder.tt - refers to a basket memberentrygen.tt - refers to a patron restriction suggestion.tt - refers to a suggestion To test, apply the patch and visit all those pages in English to make sure there is no change. 1) Go to Acquisitions 2) Search for vendors 3) On the vendors result pages, check the 'Created by' column heading of the baskets 4) Click on one of the baskets, check the basket info at the top, it should say 'Created by:' 5) Click Transfer on one of the orders 6) Search for and choose a vendor 7) In the list of that vendor's basket, it should say 'Created by' 8) Go to a patron's account 9) Add a manual restriction in the Restrictions tab at the bottom 10) In the restriction info, it should say 'Created' 11) Click on the Purchase suggestions tab on the left 12) Add a new suggestion 13) In the Suggestion management section, it should say 'Created by:' 14) Submit the suggestion 15) From the list of suggestions, click on the title 16) In Suggestion management, it should say 'Created by:' Next, install a new language (fr-CA used as example) 1) translate create fr-CA 2) open fr-CA-messages.po and add a translation for 'basket created by', 'patron restriction created on' and 'suggestion created by' (it doesn't have to be real, just write something different for each) 3) translate install fr-CA 4) in the system preferences, enable the french language in 'language' 5) change interface language to french Redo the tests above to make sure the word you put in the translation for the basket is in the places where 'Created by' refers to a basket, that the translation for the patron restriction is where it should be and that the translation you put in for the purchase suggestion is in the places where 'Created by' refers to a purchase suggestion Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24648 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.