[Bug 11890] New: Control-Click/Command-Click to open a link in a new tab not consistently working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Bug ID: 11890 Summary: Control-Click/Command-Click to open a link in a new tab not consistently working Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ed.veal@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Control-Click (PC) or Command-Click normally opens any link in a web browser into a new tab. After the 3.14 upgrade, we have discovered inconsistency in links not always having this behavior anymore on search.pl and detail.pl. This has been replicated on Master as well. On search.pl, control-clicking or command-clicking on the title links opens the link in the same window. You have to actually right-click on the link and tell the browser to open the link in a new tab. The linked author field in the search results, the call numbers, the facets on the left-hand side of the screen, the links at the top -- all will open in a new tab with the control-click or command-click option. On detail.pl, if the back to search results/next record/previous record links are present, control-clicking or command-clicking the normal/MARC/ISBD/Items/Holds/Checkout History/Barcode links open the information on the same screen. If you switch to one of the other tabs, the back to search results link is gone, and this keyboard shortcut works again. I do not see this same behavior in the OPAC. Disabling all javascript causes it to return to normal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Ed Veal from comment #0)
On search.pl, control-clicking or command-clicking on the title links opens the link in the same window.
How do you reproduce this problem? I'm not seeing it in master using Firefox.
Disabling all javascript causes it to return to normal.
This would imply that a JavaScript error on the page is to blame. Does your browser report any JavaScript errors? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- On a fresh Ubuntu package install of 3.18.3 and on a fresh kohadevbox I imported two records from LOC (Beyond Lies the Wub and Ubik, both by Philip K Dick) Rebuild zebra search for "Philip" Control+clicking title in search results opens in current tab in Firefox and Chrome, all other links on the page open in a new tab on control+click The only javascript error I see is an Uncaught TypeError: undefined is not a function -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11937 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38480&action=edit Bug 11890: Click events on titles does not work as expected The browse results feature (bug 10404) modified the click events on titles on the search result page (intranet). It introduced bad behaviors: 1/ ctrl+click on a title does not open a new tab 2/ middle click on a title does open a new tab but the browser is not displayed. Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). Test plan: 1/ On the staff interface, launch a search (catalogue/search.pl?q=XXX) 2/ When middle-clicking on a title, a new tab should open. On this tab the browse result feature should be displayed 3/ Same for cltr+click -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m CC| |jonathan.druart@biblibre.co | |m Depends on| |10404 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38480|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 38502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38502&action=edit [SIGNED OFF] Bug 11890: Click events on titles does not work as expected The browse results feature (bug 10404) modified the click events on titles on the search result page (intranet). It introduced bad behaviors: 1/ ctrl+click on a title does not open a new tab 2/ middle click on a title does open a new tab but the browser is not displayed. Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). Test plan: 1/ On the staff interface, launch a search (catalogue/search.pl?q=XXX) 2/ When middle-clicking on a title, a new tab should open. On this tab the browse result feature should be displayed 3/ Same for cltr+click Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #5 from Nick Clemens <nick@quecheelibrary.org> ---
Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users).
This is a huge improvement so signing off, would it seem ungrateful to file the above as a new bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Nick Clemens from comment #5)
Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users).
This is a huge improvement so signing off, would it seem ungrateful to file the above as a new bug?
Not at all, feel free to do it :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but this doesn't seem to work correctly: Without patch: - Search for something - From the result list, click on any record - Verify the result browser is shown on the left With patch: - Search for the same something as above - From result list, click on the same record - Verify the result browser is missing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38640&action=edit Bug 11890: Prevent default on click event It seems that the previous patch does not stop the propagation of the event if the link is clicked with the left button (which=1). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
I am sorry, but this doesn't seem to work correctly:
Without patch: - Search for something - From the result list, click on any record - Verify the result browser is shown on the left
With patch: - Search for the same something as above - From result list, click on the same record - Verify the result browser is missing
Good to have a QA step :) Sorry about that, I am sure I tested this case, the trivial one! (but it seems not with this code...) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- OPAC view: Open in new window. still opens in the same tab for me :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #10)
OPAC view: Open in new window. still opens in the same tab for me :(
Please detail, what does not work? Clicking on what and how (middle click, left click, ctrl+click)? I confirm it works here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- After sleeping over it, I think it might be out of scope of the bug. But there is another bug related to the link rewriting: If you set your OpacBaseUrl we display a link to the OPAC in the details page, that opens in a new tab by default - but currently this doesn't work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38502|0 |1 is obsolete| | Attachment #38640|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38782&action=edit [PASSED QA] Bug 11890: Click events on titles does not work as expected The browse results feature (bug 10404) modified the click events on titles on the search result page (intranet). It introduced bad behaviors: 1/ ctrl+click on a title does not open a new tab 2/ middle click on a title does open a new tab but the browser is not displayed. Note that this patch is not perfect, it fixes the 2 bad behaviors but the ctrl+click gives the focus to the new tab (could go against the preferences of the users). Test plan: 1/ On the staff interface, launch a search (catalogue/search.pl?q=XXX) 2/ When middle-clicking on a title, a new tab should open. On this tab the browse result feature should be displayed 3/ Same for cltr+click Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38783&action=edit [PASSED QA] Bug 11890: Prevent default on click event It seems that the previous patch does not stop the propagation of the event if the link is clicked with the left button (which=1). Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Improves behaviour, but there are still some problems: - left click open in new tab is missing the browser -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org