http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34955&action=edit Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34954|0 |1 is obsolete| | Attachment #34955|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34956&action=edit Bug 13516 - Tidy relevant code block -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34957|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 35098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35098&action=edit [SIGNED OFF] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch fixes the mangled display. With the patch, you will still see the lost status. See this screenshot: http://content.screencast.com/users/kylemhall/folders/Jing/media/891a082f-1c... (In reply to Katrin Fischer from comment #7)

I am not sure I understand this correctly.

1) With and without the patch my staff result list for the checked out item with lost status = 1 looks the same:

2 items, 1 available:

Books Midway Book Cart (1) Books

1 on loan:

Computer Files Midway Book Cart (1) date due: 11/01/2015 Computer Files

Should we not include the information that the item is lost somehow?

Please take a look and explain!

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38776&action=edit [PASSED QA] Bug 13516 - Display issue for search results with items both checkout out and lost If the staff search results, if an item is both checked out and lost, the result will appear as two item lines where one line has the lost status and the other line has the rest of the item's data. Test Plan: 1) Check an item out to a patron 2) Mark the item as lost *without* removing the item from the patron's record, either by using longoverdue.pl or by editing the itemlost field in the database directly. 3) Perform a search where that item will be in the results 4) Note the improper display of the item's data 5) Apply this patch set 6) Reload the search restults 7) Note the item now displays correctly Signed-off-by: Nick <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> http://bugs.koha-community.org/show_bug.cgi?id=13561 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35097|0 |1 is obsolete| | Attachment #35098|0 |1 is obsolete| | Attachment #38776|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38777&action=edit [PASSED QA] Bug 13516 - Tidy relevant code block Signed-off-by: Nick <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.