[Bug 21398] New: Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Bug ID: 21398 Summary: Search term when adding an order from an existing record should be required Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Otherwise we get this ugly screen: https://snag.gy/U8X3ZK.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 79265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79265&action=edit Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79265|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 79468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79468&action=edit Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple fix, does what it says on the tin. Signing Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79468|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 79473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79473&action=edit Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works, but looks a bit different than other places we have required fields (no red label, no *, no red required showing up behind the field - but maybe it would not look right in this case?) No blocker for me, just noting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #5)
This works, but looks a bit different than other places we have required fields (no red label, no *, no red required showing up behind the field - but maybe it would not look right in this case?) No blocker for me, just noting.
The message when nothing is entered looks good so i think that suffices here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I tried the label in red but it looked bad, it takes too much visibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #8)
I tried the label in red but it looked bad, it takes too much visibility.
I think you are right, it would be too prominent, when the search is only one valid option on the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org