[Bug 38285] New: Replace instances of obsolete Bootstrap class "pull-right"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Bug ID: 38285 Summary: Replace instances of obsolete Bootstrap class "pull-right" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 Bootstrap 5 doesn't have the "pull-right" class, and we have some instances of it which were not caught during the upgrade. Most commonly we see it on dropdown menus, where it may be able to be removed without replacing it with a different class. Bootstrap 5 menus are more responsive than previous versions. Otherwise "pull-right" on dropdowns can be replaced with "dropdown-menu-end". Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 174079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174079&action=edit Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" This patch fixes instances where the pre-Bootstrap-5 class "pull-right" was missed during the upgrade. Most cases were on dropdown menus, and in all of these cases the class can be removed because Bootstrap 5 menus have better responsive behavior. Other changes: Added "dropdown-item" classes to some menu items which lacked it; Added some custom style for the "Filter" form in the patron permissions toolbar. To test, apply the patch and rebuild the staff interface CSS. Test that the following menus look correct and work correctly: - Catalog -> Bibliographic details page -> Holdings table: The "Edit" secondary menu shown for each item (requires that the LocalCoverImages system preference be enabled. - Administration -> Z39.50 servers: The "Actions" menu for each server in the list of servers. - Circulation -> Article requests: The "Actions" menu for each title and under each tab (New, Pending, and Processing). - Tools -> Patron lists: "Actions" menu. - Administration -> Plugins: "Actions" menu (requires that you have at least one plugin installed). - Reports -> Saved SQL reports: The secondary menu on each saved report's "Run" button . - Cataloging -> Rotating collections: "Actions" menu. - Serials -> Subscription search results: In the "Open" tab, the secondary menu on the "Serial receive" button on each subscription. In the "Closed" tab, the "Actions" menu. - Acquistions -> Suggestions: The secondary menu on each title's "Edit" button. - Tools -> HTML customizations: The secondary menu on the "New entry" button; The secondary menu on each entry's "Edit" button; Edit entry -> The secondary menu on the "Save" button. - Cataloging -> Stock rotation: The "Manage" menu on each rota. A non-menu change: - Patrons -> Patron details -> More -> Set permissions: CSS has been added to correctly align the "Filter" menu. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174079|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 175023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175023&action=edit Bug 38285: Replace instances of obsolete Bootstrap class "pull-right" This patch fixes instances where the pre-Bootstrap-5 class "pull-right" was missed during the upgrade. Most cases were on dropdown menus, and in all of these cases the class can be removed because Bootstrap 5 menus have better responsive behavior. Other changes: Added "dropdown-item" classes to some menu items which lacked it; Added some custom style for the "Filter" form in the patron permissions toolbar. To test, apply the patch and rebuild the staff interface CSS. Test that the following menus look correct and work correctly: - Catalog -> Bibliographic details page -> Holdings table: The "Edit" secondary menu shown for each item (requires that the LocalCoverImages system preference be enabled. - Administration -> Z39.50 servers: The "Actions" menu for each server in the list of servers. - Circulation -> Article requests: The "Actions" menu for each title and under each tab (New, Pending, and Processing). - Tools -> Patron lists: "Actions" menu. - Administration -> Plugins: "Actions" menu (requires that you have at least one plugin installed). - Reports -> Saved SQL reports: The secondary menu on each saved report's "Run" button . - Cataloging -> Rotating collections: "Actions" menu. - Serials -> Subscription search results: In the "Open" tab, the secondary menu on the "Serial receive" button on each subscription. In the "Closed" tab, the "Actions" menu. - Acquistions -> Suggestions: The secondary menu on each title's "Edit" button. - Tools -> HTML customizations: The secondary menu on the "New entry" button; The secondary menu on each entry's "Edit" button; Edit entry -> The secondary menu on the "Save" button. - Cataloging -> Stock rotation: The "Manage" menu on each rota. A non-menu change: - Patrons -> Patron details -> More -> Set permissions: CSS has been added to correctly align the "Filter" menu. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes CSS class release notes| |changes that were missed | |during the Bootstrap 5 | |upgrade: | |- Removes | |instances of the | |pre-Bootstrap-5 class | |"pull-right" (Bootstrap 5 | |menus have better | |responsive behavior). | |- | |Adds "dropdown-item" | |classes to some menu items | |that lacked it. | |- Adds some | |custom style for the | |"Filter" form in the patron | |permissions toolbar (it is | |now correctly aligned). | |(This is related to the | |OPAC and staff interface | |Bootstrap 5 upgrade in Koha | |24.11.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38608 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38026 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 38608 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Bug 38285 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes CSS class |This fixes some CSS from release notes|changes that were missed |the Bootstrap 5 upgrade: |during the Bootstrap 5 |- |upgrade: |Removes instances of the |- Removes |pre-Bootstrap-5 class |instances of the |"pull-right" (Bootstrap 5 |pre-Bootstrap-5 class |menus have better |"pull-right" (Bootstrap 5 |responsive behavour). |menus have better |- |responsive behavior). |Adds "dropdown-item" |- |classes to some menu items |Adds "dropdown-item" |that lacked it. |classes to some menu items |- Adds some |that lacked it. |custom style for the |- Adds some |"Filter" form in the patron |custom style for the |permissions toolbar (it is |"Filter" form in the patron |now correctly aligned). |permissions toolbar (it is |(This is related to the |now correctly aligned). |OPAC and staff interface |(This is related to the |Bootstrap 5 upgrade in Koha |OPAC and staff interface |24.11.) |Bootstrap 5 upgrade in Koha | |24.11.) | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA by RM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38285 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org