[Bug 38077] New: Minor spacing issue in self checkout login page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Bug ID: 38077 Summary: Minor spacing issue in self checkout login page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When accessing the sco-main.pl page, there is no space between the password field and the login button. A little padding there would look better. To get there: If using KTD, 1. Go to http://kohadev.mydnsname.org:8080/cgi-bin/koha/sco/sco-main.pl If not using KTD, 1. Create a patron with the self_checkout_module permission 2. In system preferences, - set WebBasedSelfCheck to Enable - set AutoSelfCheckAllowed to Allow - enter the login of the patron created in step 1 in AutoSelfCheckID - enter the password of the patron created in step 1 in AutoSelfCheckPass 3. Go to opac/cgi-bin/koha/sco/sco-main.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Same thing if SelfCheckoutByLogin is set to cardnumber. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175576&action=edit Bug 38077: Fix minor spacing issue in self checkout login page This patch adjusts the markup and CSS of the self checkout login screen so that form layout is consistent and readable. I have adjusted the template conditional so that it re-uses more form elements like <legend>. To test, apply the patch and enable WebBasedSelfCheck if necessary. - Set the SelfCheckoutByLogin system preference to 'cardnumber' - Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl) - The login form should be labeled "Log in to your account" followed by the label, form field, and submit button arranged vertically. - Set the SelfCheckoutByLogin preference to "username and password" - Reload the self-checkout page. The form should look the same with the addition of the password field. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175576|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 175581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175581&action=edit Bug 38077: Fix minor spacing issue in self checkout login page This patch adjusts the markup and CSS of the self checkout login screen so that form layout is consistent and readable. I have adjusted the template conditional so that it re-uses more form elements like <legend>. To test, apply the patch and enable WebBasedSelfCheck if necessary. - Set the SelfCheckoutByLogin system preference to 'cardnumber' - Go to the self-checkout page (/cgi-bin/koha/sco/sco-main.pl) - The login form should be labeled "Log in to your account" followed by the label, form field, and submit button arranged vertically. - Set the SelfCheckoutByLogin preference to "username and password" - Reload the self-checkout page. The form should look the same with the addition of the password field. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a minor spacing release notes| |issue on the self checkout | |login page. The login form | |is now arranged vertically | |and includes more padding. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After applying the patch, run yarn build -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- QA by RM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38077 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x (or 23.XX) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org