[Bug 19789] New: Remove some indirect DBIx calls from updatedatabase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Bug ID: 19789 Summary: Remove some indirect DBIx calls from updatedatabase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Triggered by a comment on 19096. What happens when DBIx schema does not match table design? Add a field to schema file that does not exist => Koha::Object->new and store still works, Koha::Objects->search still works but an actual fetch by calling ->next is enough to crash. DBD::mysql::st execute failed: Unknown column 'me.iserniet' in 'field list' Add a field to the table but not to the schema file => Seems to work still Dubious lines in updatedatabase L12389 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings; This includes Koha Objects calls to Koha::SearchFields and Koha::SearchMarcMaps. The sub add_to_search_marc_maps in Koha::SearchField puzzles me. Does this work, why is there no test associated with it ? Any (future) new column in search fields or search marc maps may lead to a crash at 3.23.00.050 L13526 and context: Koha::Number::Price->new( $order->{rrp} )->round; Only new calls seem to be fine. But might be tricky. L14364 and context: Koha::Holds->search({ found => 'W', priority => 0 }); Any future change in reserves table may lead to a crash on the next statement in 16.12.00.032. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20922 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #0)
L13526 and context: Koha::Number::Price->new( $order->{rrp} )->round; Only new calls seem to be fine. But might be tricky.
Done on bug 20922. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20922 Blocks|20922 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Bug 19789 depends on bug 20922, which changed state. Bug 20922 Summary: Koha::Number::Price must not be used in updatedatabase.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21931 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #0)
Dubious lines in updatedatabase L12389 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings; This includes Koha Objects calls to Koha::SearchFields and Koha::SearchMarcMaps. The sub add_to_search_marc_maps in Koha::SearchField puzzles me. Does this work, why is there no test associated with it ? Any (future) new column in search fields or search marc maps may lead to a crash at 3.23.00.050
Reported on bug 21931. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 [Bug 21931] Upgrade from 3.22 to 18.11 fails when running updatedatabase.pl script -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Bug 19789 depends on bug 21931, which changed state. Bug 21931 Summary: Upgrade from 3.22 fails when running updatedatabase.pl script https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21931 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23265 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #0)
L14364 and context: Koha::Holds->search({ found => 'W', priority => 0 }); Any future change in reserves table may lead to a crash on the next statement in 16.12.00.032.
See bug 23265. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 [Bug 23809] Update to DB revision 16.12.00.032 fails: `Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371.` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think we are good for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org