https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19789 Bug ID: 19789 Summary: Remove some indirect DBIx calls from updatedatabase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Triggered by a comment on 19096. What happens when DBIx schema does not match table design? Add a field to schema file that does not exist => Koha::Object->new and store still works, Koha::Objects->search still works but an actual fetch by calling ->next is enough to crash. DBD::mysql::st execute failed: Unknown column 'me.iserniet' in 'field list' Add a field to the table but not to the schema file => Seems to work still Dubious lines in updatedatabase L12389 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings; This includes Koha Objects calls to Koha::SearchFields and Koha::SearchMarcMaps. The sub add_to_search_marc_maps in Koha::SearchField puzzles me. Does this work, why is there no test associated with it ? Any (future) new column in search fields or search marc maps may lead to a crash at 3.23.00.050 L13526 and context: Koha::Number::Price->new( $order->{rrp} )->round; Only new calls seem to be fine. But might be tricky. L14364 and context: Koha::Holds->search({ found => 'W', priority => 0 }); Any future change in reserves table may lead to a crash on the next statement in 16.12.00.032. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.