[Bug 4210] New: Acquisitions suggestion templates have library name field, but data is not passed
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 Summary: Acquisitions suggestion templates have library name field, but data is not passed Product: Koha Version: HEAD Platform: PC OS/Version: Windows 2000 Status: ASSIGNED Severity: minor Priority: P5 Component: Acquisitions AssignedTo: jwagner@ptfs.com ReportedBy: jwagner@ptfs.com Estimated Hours: 0.0 Change sponsored?: --- The various acquisitions suggestion templates in kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion have a line like: Dear <!-- TMPL_VAR NAME="LibraryName" --> user, but the LibraryName variable is not passed to the suggestions script. I modified C4/Suggestions.pm to add it into the list being passed to the templates: LibraryName => C4::Context->preference("LibraryName") -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 --- Comment #1 from Jane Wagner <jwagner@ptfs.com> 2010-02-17 19:44:25 --- Created an attachment (id=1639) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1639) patch file Patch sent February 17, 2010. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 --- Comment #2 from Jane Wagner <jwagner@ptfs.com> 2010-02-18 16:55:27 --- My apologies -- I thought I was building the patch on a system updated to current head, but I wasn't. The problem still exists at current head, but the suggestion code has changed a lot. At first glance, I'm not sure where to do the fix. Maybe someone from BibLibre could do it? If not, I'll work on it when I have time and resubmit a patch. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 --- Comment #3 from Jane Wagner <jwagner@ptfs.com> 2010-02-25 17:42:30 --- I think I've found the right place to fix this in current head (code has moved from Suggestions.pm to suggestion.pl). Is adding LibraryName into this section correct? foreach my $element qw(managedby suggestedby){ # $debug || warn $$suggestion_ref{$element}; if ($$suggestion_ref{$element}){ my $member=GetMember(borrowernumber=>$$suggestion_ref{$element}); $template->param( $element."_borrowernumber"=>$$member{borrowernumber}, $element."_firstname"=>$$member{firstname}, $element."_surname"=>$$member{surname}, $element."_branchcode"=>$$member{branchcode}, $element."_LibraryName"=>C4::Context->preference("LibraryName"), $element."_description"=>$$member{description}, $element."_category_type"=>$$member{category_type} ); } } -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 --- Comment #4 from Jane Wagner <jwagner@ptfs.com> 2010-02-25 17:55:51 --- Wrong place -- thanks to hdl_laptop on the IRC. It should be added in Suggestions.pm under the EnqueueLetter section: my $enqueued = C4::Letters::EnqueueLetter({ letter=>$letter, borrowernumber=>$suggestion->{suggestedby}, suggestionid=>$suggestion->{suggestionid}, LibraryName => C4::Context->preference("LibraryName"), msg_transport_type=>'email' }); I'll do a patch. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 --- Comment #5 from Jane Wagner <jwagner@ptfs.com> 2010-02-25 18:00:54 --- Created an attachment (id=1694) --> (http://bugs.koha.org/cgi-bin/bugzilla3/attachment.cgi?id=1694) patch against current head Revised patch sent February 25, 2010. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> 2010-04-30 02:14:29 --- Patch pushed. Please test and close. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 --- Comment #7 from Jane Wagner <jwagner@ptfs.com> 2010-04-30 13:56:33 --- I've tried testing, but I'm not now getting any emails at all from suggestions. Not sure if the problem is with the patch or with my setup. Can someone else test? -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4210 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #8 from Jane Wagner <jwagner@ptfs.com> 2010-05-12 13:54:54 --- The fix for this bug (in ptfs-harley) can also be pulled from the public git repository at http://github.com/Koha-PTFS, branch Bug4210 -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com