[Bug 23537] New: Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Bug ID: 23537 Summary: Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator Some items from overdrive, such as magazines, don't have a primaryCreator in their object. When Koha gets a result like this, the overdrive search won't show any results after the first to have this condition, because it's trying to push an undefined property. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92586&action=edit Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=k... Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |wizzyrea@gmail.com CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92586|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92706&action=edit Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=k... Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92706|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 93036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93036&action=edit Bug 23537: Overdrive won't show complete results at all times To test: On an overdrive enabled OPAC (tough sell, I know) Do a search for something you know has magazines, the collection I was looking at had "knit" as one Without this patch, the results will show "(many) items found in overdrive collection" but only show a small number of them. With the patch, the number of results should match the number shown/paginated. A site that has this fix applied, is https://tracy.bywatersolutions.com/cgi-bin/koha/opac-overdrive-search.pl?q=k... Before this patch, the number of results was 44, but there were only 8 shown. Now we see all 44 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.04 released in| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- One-line patch, I choose to backport to 19.05.x Pushed to 19.05.x for 19.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org