[Bug 31694] New: MARC overlay rules presets don't change anything if presets are translated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Bug ID: 31694 Summary: MARC overlay rules presets don't change anything if presets are translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In MARC overlay rules, if the preset names are not in English, the settings don't change. Example 1. In staff interface in English, go to Administration > MARC overlay rules 2. In the 'Preset' column, try the different options. Notice the Added, Appended, Removed, Deleted settings change according to the preset you chose 3. Change interface in another language (I tried fr-CA and de-DE) 4. Try the presets again. Note that if the preset name is in English (some in fr-CA are not translated), the settings change, but if the preset name is translated, nothing changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm putting this as 'normal', maybe it should be 'major'... The functionality doesn't work in other languages than English -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 141401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141401&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I provided a patch... I just changed the option names to make them different from their labels. Since they were the same, I think the translator tool translated everything, name and label, and it couldn't recognize it afterwards... I hope that was the correct correction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Ok my patch doesn't 100% work. If you save the rule, it's the option name (the ugly one) rather than the label that appears... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we should remove the translations here? - overlay_rules_presets[_("Overwrite")] = { + overlay_rules_presets[_("overwrite")] = { So maybe: - overlay_rules_presets[_("Overwrite")] = { + overlay_rules_presets["Overwrite"] = { -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141401|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142579&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142580&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142580|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142598&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I don't think we're quite there yet :/ Without the patch, in English, when we select let's say 'Add and append' and save the rule, the words 'Add and append' still appear in the preset column of the saved rule. With the patch, the preset is saved as 'Custom' 1. Without the patch, go to Administration > MARC overlay rules 2. Enter the following rule - Module: Source - Filter: Staged MARC import - Tag: 6.. - Preset: Add and append 3. Click 'Add rule' --> In the 'Preset' column, the saved rule says 'Add and append' 4. Delete the rule (click 'Delete' and confirm) 5. Apply the patch 6. Redo steps 2-3 --> In the 'Preset' column, the saved rule says 'Custom' I also noticed, after I applied the patch and updated my po's (`gulp po:update --lang fr-CA`) that I still had two strings "User category" #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:159 #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-overlay-rules.tt:161 #, c-format msgid "User category" msgstr "Catégorie d'utilisateurs" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142579|0 |1 is obsolete| | --- Comment #10 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 144407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144407&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch uses the text of option (which is translated) instead of the value (which is not translated) for the process. Test plan: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Attachment #142598|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, a little sad to see my patch just thrown out without comment. I think we still need a lot of fixes there for translatability. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142598|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144407|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142579|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | --- Comment #12 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Sorry. The patch I added is supposed to fix this bug, but I'll try to add on what is already done. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #13 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 144408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144408&action=edit Bug 31694: (follow-up) Fix preset display issue Preset column should now display the right preset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #14 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 144409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144409&action=edit wrong preset caused by different fr-CA translation On a side note, there is a small issue in fr-CA preset display. The word "Remove" is translated into "Retirer" in column "Retiré" ("Removed" in en), but other instances of "Remove" are translated to "Enlever" so it messes up the preset display. The problem is fixed if instead of "Retirer" it's "Enlever". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #15 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 149601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149601&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With then patch it appears correctly (e.g. Outrepasser) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Kevin Carnes <kevin.carnes@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149601|0 |1 is obsolete| | --- Comment #16 from Kevin Carnes <kevin.carnes@ub.lu.se> --- Created attachment 149602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149602&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With the patch it appears correctly (e.g. Outrepasser) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142579|0 |1 is obsolete| | --- Comment #17 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155123&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142598|0 |1 is obsolete| | --- Comment #18 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155124&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144408|0 |1 is obsolete| | --- Comment #19 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155125&action=edit Bug 31694: (follow-up) Fix preset display issue Preset column should now display the right preset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149602|0 |1 is obsolete| | --- Comment #20 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 155126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155126&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With the patch it appears correctly (e.g. Outrepasser) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #21 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we get a sign-off here please? It's not only a translations problem, but also a problem with using this form in any other language. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155123|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 159121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159121&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155124|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 159122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159122&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155125|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 159123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159123&action=edit Bug 31694: (follow-up) Fix preset display issue Preset column should now display the right preset. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155126|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 159124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159124&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With the patch it appears correctly (e.g. Outrepasser) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #27 from David Nind <david@davidnind.com> --- I have tested and got things to work as far as I could tell. Since translation is not something all that familiar to me, may be a second sign off would be useful? Testing notes using koha-testing-docker (KTD): 1. Not related to this bug. With the recent changes to languages in master, the normal commands for updating and installing a language didn't work as expected for me. See [1] for the errors and my work around. 2. After applying the patches, but before step 7 of the main patch, I had to update and install the language again. [1] Installing and updating translations using KTD ================================================== Error when using gulp po:update ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I got an error when using the command (maybe need to access using ktd --root --shell ?): kohadev-koha@kohadevbox:koha(bz31694)$ gulp po:update [20:04:18] Using gulpfile /kohadevbox/koha/gulpfile.js [20:04:18] Starting 'po:update'... [20:04:18] Starting 'po_update_marc_marc21'... [20:04:18] Starting 'po_update_marc_unimarc'... [20:04:18] Starting 'po_update_staff'... [20:04:18] Starting 'po_update_opac'... [20:04:18] Starting 'po_update_pref'... [20:04:18] Starting 'po_update_messages'... [20:04:18] Starting 'po_update_messages_js'... [20:04:18] Starting 'po_update_installer'... [20:04:18] Starting 'po_update_installer_marc21'... [20:04:18] Starting 'po_update_installer_unimarc'... [20:04:25] Finished 'po_update_installer_unimarc' after 6.41 s [20:04:29] Finished 'po_update_installer_marc21' after 10 s [20:04:29] Finished 'po_update_installer' after 10 s [20:04:29] Finished 'po_update_marc_unimarc' after 10 s [20:04:29] Finished 'po_update_pref' after 10 s [20:04:29] Finished 'po_update_marc_marc21' after 10 s [20:04:32] Finished 'po_update_messages_js' after 14 s [20:04:32] Finished 'po_update_opac' after 14 s [20:04:34] 'po_update_messages' errored after 15 s [20:04:34] Error: Command failed: msgmerge --backup=off --no-wrap --quiet -F --update misc/translator/po/vi-VN-messages.po misc/translator/Koha-messages.pot misc/translator/Koha-messages.pot:11:35: syntax error misc/translator/Koha-messages.pot:11: keyword "n" unknown misc/translator/Koha-messages.pot:12: end-of-line within string msgmerge: found 3 fatal errors at ChildProcess.exithandler (node:child_process:422:12) at ChildProcess.emit (node:events:517:28) at ChildProcess.emit (node:domain:552:15) at maybeClose (node:internal/child_process:1098:16) at Socket.<anonymous> (node:internal/child_process:450:11) at Socket.emit (node:events:517:28) at Socket.emit (node:domain:552:15) at Pipe.<anonymous> (node:net:350:12) at Pipe.callbackTrampoline (node:internal/async_hooks:130:17) [20:04:34] 'po:update' errored after 15 s Permission errors when using misc/translator/translate ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I also got permission errors when using misc/translator/translate: misc/translator/translate update fr-FR misc/translator/translate install fr-FR mkdir /kohadevbox/koha/misc/translator/po/fr_FR: Permission denied at /kohadevbox/koha/misc/translator/LangInstaller.pm line 454. sudo misc/translator/translate install fr-FR Can't locate C4/Context.pm in @INC (you may need to install the C4::Context module) (@INC contains: /kohadevbox/koha/misc/translator /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.32.1 /usr/local/share/perl/5.32.1 /usr/lib/x86_64-linux-gnu/perl5/5.32 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl-base /usr/lib/x86_64-linux-gnu/perl/5.32 /usr/share/perl/5.32 /usr/local/lib/site_perl) at /kohadevbox/koha/misc/translator/LangInstaller.pm line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/misc/translator/LangInstaller.pm line 22. Compilation failed in require at ./translate line 28. BEGIN failed--compilation aborted at ./translate line 28. Work around ~~~~~~~~~~~ In the end, I accessed KTD using root to update and install languages. david@david-thinkpad-t14:~/git-koha/koha-testing-docker$ ktd --root --shell root@kohadevbox:kohadevbox$ cd koha root@kohadevbox:koha$ misc/translator/translate update fr-FR root@kohadevbox:koha$ misc/translator/translate install fr-FR root@kohadevbox:koha$ chown -R kohadev-koha:kohadev-koha misc/translator/po -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159124|0 |1 is obsolete| | --- Comment #28 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 159192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159192&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With the patch it appears correctly (e.g. Outrepasser) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #29 from Jan Kissig <bibliothek@th-wildau.de> --- In my case (via ktd koha testing docker) to install de-DE I had to: $ ktd --root --shell root@kohadevbox:~$ cd /kohadevbox/koha root@kohadevbox:koha(bug_31694)$ git clone https://gitlab.com/koha-community/koha-l10n.git misc/translator/po root@kohadevbox:koha(bug_31694)$ misc/translator/translate install de-DE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- @Jan: you meant to signoff the 4 patches, right? Not just the last, "Bug 31694: (follow-up) Use values for operations to avoid translation issues" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159121|0 |1 is obsolete| | Attachment #159122|0 |1 is obsolete| | Attachment #159123|0 |1 is obsolete| | Attachment #159192|0 |1 is obsolete| | --- Comment #31 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 159250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159250&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #32 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 159251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159251&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #33 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 159252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159252&action=edit Bug 31694: (follow-up) Fix preset display issue Preset column should now display the right preset. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #34 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 159253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159253&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With the patch it appears correctly (e.g. Outrepasser) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #35 from Jan Kissig <bibliothek@th-wildau.de> --- (In reply to Victor Grousset/tuxayo from comment #30)
@Jan: you meant to signoff the 4 patches, right? Not just the last, "Bug 31694: (follow-up) Use values for operations to avoid translation issues"
@Victor, yes I meant to signoff these 4 patches, just getting familiar with git bz and hope that it worked now as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Jan Kissig from comment #35)
@Victor, yes I meant to signoff these 4 patches, just getting familiar with git bz and hope that it worked now as expected
All looks good :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159250|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160194&action=edit Bug 31694: MARC overlay rules presets don't change anything if presets are translated This patch corrects option value names in MARC overlay rules to prevent them from being translated. To test: 1. Install a new language 1.1. In a terminal, run the following commands gulp po:update cd misc/translator ./translate install xx-XX 1.2. Go to Administration > Global system preferences 1.3. Search for language 1.4. In the language syspref check the box for the language you just installed 1.5. Save 2. In the staff interface in English, go to Administration > Record overlay rules 3. In the column 'Preset' try the various options, note that the 'Added', 'Appended', 'Removed', and 'Deleted' settings change depending on the chosen preset 4. Change the interface language 5. Redo step 3, notice that if the preset name is translated, the other settings don't change 6. Apply patch 7. Redo step 3, the presets should now change the settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159251|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160195&action=edit Bug 31694: (follow-up) Further improve translatability To test: * Add rules fo different modules and with different settings * Verify the saved module description for a saved rule matches the pull down * Verify the saved filter matches the pull downs (especially for source and patron category) Also: * Renames 'User category' to 'Patron category' * Remove some values from translations, that shouldn't be translated, like value attributs for options. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159252|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160196&action=edit Bug 31694: (follow-up) Fix preset display issue Preset column should now display the right preset. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159253|0 |1 is obsolete| | --- Comment #40 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160197&action=edit Bug 31694: (follow-up) Use values for operations to avoid translation issues To test: * Try adding a preset rule that has an operation with different translations for the column and the pull down (e.g. Outrepasser for fr-CA) * Without the patch it appears as Custom (e.g. Personnalisé) * With the patch it appears correctly (e.g. Outrepasser) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jan Kissig <jkissig@th-wildau.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 160198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160198&action=edit Bug 31694: Add missing TT filters Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Patch works well, QA script doesn't complain. Passing QA. One remark: when editing a rule, the "custom" preset is always selected, even if a preset have been used. But this problem exists in master too, so not caused by these patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Julian Maurice from comment #42)
Patch works well, QA script doesn't complain. Passing QA.
One remark: when editing a rule, the "custom" preset is always selected, even if a preset have been used. But this problem exists in master too, so not caused by these patches.
Agreed, thanks for the testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #45 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.02 |24.05.00,23.11.02,23.05.08 released in| | CC| |lucas@bywatersolutions.com --- Comment #46 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #47 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31694 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #48 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- If I understand correctly, this is a bug fix and doesn't change anything in the interface or the way to use the functionality. Nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org