[Bug 38180] New: Don't show label if 520 ind1=8 (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Bug ID: 38180 Summary: Don't show label if 520 ind1=8 (MARC21) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Bug 29471 added the display of field 520 in the detailed record in the staff interface for MARC21. According to the MARC21 standard (https://www.loc.gov/marc/bibliographic/bd520.html) there should not be a label before the content of the field if ind1 = 8 (no display constant). Currently, if ind1 = 8, it shows 'Summary'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 172793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172793&action=edit Bug 38180: Don't show label if 520 ind1=8 (MARC21) This patch amends the display constant for field 520 if the first indicator is set to 8. According to MARC21 documentation (https://www.loc.gov/marc/bibliographic/bd520.html), the field's labels depend on the value of indicator 1. First Indicator Second Indicator Display constant controller empty - Summary 0 - Subject 1 - Review 2 - Scope and content 3 - Abstract 4 - Content advice 8 - No display constant generated Prior to this patch, a 520 field with ind1 = 8 is displayed as 'Summary'. After this patch, there is no label. To test: 1. Create or edit a record, and add 7 x 520 tags: - Add one 520 tag with no value in ind1, enter 'Summary' in 520$a - Add one 520 tag with 0 in ind1, enter 'Subject' in 520$a - Add one 520 tag with 1 in ind1, enter 'Review' in 520$a - Add one 520 tag with 2 in ind1, enter 'Scope and content' in 520$a - Add one 520 tag with 3 in ind1, enter 'Abstract' in 520$a - Add one 520 tag with 4 in ind1, enter 'Content advice' in 520$a - Add one 520 tag with 8 in ind1, enter 'No display constant generated' in 520$a 2. View the record in the staff interface --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - 'Summary' for the field that contains 'Subject' **(NOT OK)** 3. View the record in the OPAC --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - 'Summary' for the field that contains 'Subject' **(NOT OK)** 4. Apply patch 5. Repeat step 2 (view the record in the staff interface; make sure to refresh the page) --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - Nothing for the field that contains 'Subject' (OK!!) 6. Repeat step 3 (view the record in the OPAC; make sure to refresh the page) --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - Nothing for the field that contains 'Subject' (OK!!) https://bugs.koha-community.org/show_bug.cgi?id=38081 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172793|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 172922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172922&action=edit Bug 38180: Don't show label if 520 ind1=8 (MARC21) This patch amends the display constant for field 520 if the first indicator is set to 8. According to MARC21 documentation (https://www.loc.gov/marc/bibliographic/bd520.html), the field's labels depend on the value of indicator 1. First Indicator Second Indicator Display constant controller empty - Summary 0 - Subject 1 - Review 2 - Scope and content 3 - Abstract 4 - Content advice 8 - No display constant generated Prior to this patch, a 520 field with ind1 = 8 is displayed as 'Summary'. After this patch, there is no label. To test: 1. Create or edit a record, and add 7 x 520 tags: - Add one 520 tag with no value in ind1, enter 'Summary' in 520$a - Add one 520 tag with 0 in ind1, enter 'Subject' in 520$a - Add one 520 tag with 1 in ind1, enter 'Review' in 520$a - Add one 520 tag with 2 in ind1, enter 'Scope and content' in 520$a - Add one 520 tag with 3 in ind1, enter 'Abstract' in 520$a - Add one 520 tag with 4 in ind1, enter 'Content advice' in 520$a - Add one 520 tag with 8 in ind1, enter 'No display constant generated' in 520$a 2. View the record in the staff interface --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - 'Summary' for the field that contains 'Subject' **(NOT OK)** 3. View the record in the OPAC --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - 'Summary' for the field that contains 'Subject' **(NOT OK)** 4. Apply patch 5. Repeat step 2 (view the record in the staff interface; make sure to refresh the page) --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - Nothing for the field that contains 'Subject' (OK!!) 6. Repeat step 3 (view the record in the OPAC; make sure to refresh the page) --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - Nothing for the field that contains 'Subject' (OK!!) https://bugs.koha-community.org/show_bug.cgi?id=38081 Signed-off-by: esther <esther@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |esther.melander@bywatersolu | |tions.com --- Comment #3 from Esther Melander <esther.melander@bywatersolutions.com> --- There was no label for tag 520 when the first indicator is an 8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes the logic release notes| |in the MARC21 XSLT files to | |not show a label on the 520 | |field if the first | |indicator is set to 8. QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172922|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 177401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177401&action=edit Bug 38180: Don't show label if 520 ind1=8 (MARC21) This patch amends the display constant for field 520 if the first indicator is set to 8. According to MARC21 documentation (https://www.loc.gov/marc/bibliographic/bd520.html), the field's labels depend on the value of indicator 1. First Indicator Second Indicator Display constant controller empty - Summary 0 - Subject 1 - Review 2 - Scope and content 3 - Abstract 4 - Content advice 8 - No display constant generated Prior to this patch, a 520 field with ind1 = 8 is displayed as 'Summary'. After this patch, there is no label. To test: 1. Create or edit a record, and add 7 x 520 tags: - Add one 520 tag with no value in ind1, enter 'Summary' in 520$a - Add one 520 tag with 0 in ind1, enter 'Subject' in 520$a - Add one 520 tag with 1 in ind1, enter 'Review' in 520$a - Add one 520 tag with 2 in ind1, enter 'Scope and content' in 520$a - Add one 520 tag with 3 in ind1, enter 'Abstract' in 520$a - Add one 520 tag with 4 in ind1, enter 'Content advice' in 520$a - Add one 520 tag with 8 in ind1, enter 'No display constant generated' in 520$a 2. View the record in the staff interface --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - 'Summary' for the field that contains 'Subject' **(NOT OK)** 3. View the record in the OPAC --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - 'Summary' for the field that contains 'Subject' **(NOT OK)** 4. Apply patch 5. Repeat step 2 (view the record in the staff interface; make sure to refresh the page) --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - Nothing for the field that contains 'Subject' (OK!!) 6. Repeat step 3 (view the record in the OPAC; make sure to refresh the page) --> The labels should be - 'Summary' for the field that contains 'Summary' (OK) - 'Subject' for the field that contains 'Subject' (OK) - 'Review' for the field that contains 'Review' (OK) - 'Scope and content' for the field that contains 'Scope and content' (OK) - 'Abstract' for the field that contains 'Abstract' (OK) - 'Content advice' for the field that contains 'Content advice' (OK) - Nothing for the field that contains 'Subject' (OK!!) https://bugs.koha-community.org/show_bug.cgi?id=38081 Signed-off-by: esther <esther@bywatersolutions.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thank you Caroline for such a detailed test plan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |oleonard@myacpl.org --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This will leave an empty HTML elements: <span class="results_summary summary"> <span class="label"> I am a bit worried if this poses a problem with accessibility. It might be cleaner to check for indicator and then not generate the HTML tag at all. Adding Owen for HTML advice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #6)
I am a bit worried if this poses a problem with accessibility.
I'm not aware of an accessibility problem. The HTML is still valid, and the WebAIM browser tool doesn't flag it.
It might be cleaner to check for indicator and then not generate the HTML tag at all.
Ideally yes, but since it doesn't seem to be causing a problem I think a simple solution is fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38180 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #10 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Specificities of XLST are not documented in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org