[Bug 41131] New: Branch Transfer Limits basic editor allows one to prevent transfers from a library to itself and block related holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Bug ID: 41131 Summary: Branch Transfer Limits basic editor allows one to prevent transfers from a library to itself and block related holds Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com The branch transfer limits basic editor will always indicate that transfers from a branch to itself are allowed -- when the page loads, it always puts a checkmark under "Allow transfer" for the branch for which one is defining limits. But this checkmark is not reflected in the database. To recreate: - disable AllowHoldPolicyOverride - set UseBranchTransferLimits to Enforce; set BranchTransferLimitsType to itemtype (the also exists when enforcing by collection code, but its impact on holds is easier to see with itemtypes) - go to the branch transfer limits page, see that Allow Transfers is checked for all branches and all itemtypes - in a report, SELECT * FROM branch_transfer_limits, confirm no results -- we put a row in this table for every transfer that's blocked - back on the branch transfer limits, uncheck "Allow transfer" for Books going from Centerville to Centerville, click Save - On save, the page reloads and shows a checkmark under "Allow transfer" for Books going from Centerville to Centerville - back in reports, run your query again, see there is a row in branch_transfer_limits to block the transfer of Books from Centerville to Centerville - Attempt to place a hold on an item currently at Centerville for pickup at Centerville, confirm Koha will not allow this hold This cannot be recreated in the advanced editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188561&action=edit Bug 41131: Don't allow limiting transfers from/to a single branch We say that you cannot limit transfers internally within a branch, but it seems we do allow you to, and don't show you when we do To test: 1 - Go to Admin->Library transfer limits 2 - On a branches page, uncheck the box for that branch e.g. don't allow FIC to transfer to CPL from CPL 3 - Save 4 - Note the box is still checked 5 - Check the DB SELECT * FROM branch_transfer_limits; 6 - There is a line to/from CPL! 7 - Apply patches 8 - updatedatabase 9 - Repeat 5 - the line is deleted! 10 - Try to create the rule again, not the box is now disabled 11 - Be sneaky, enable the box, uncheck it and save, no rule created 12 - Be sneaky, edit the HMTL for another button to make it limiting CPL to CPL, save, no rule created 13 - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188561|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 190482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190482&action=edit Bug 41131: Don't allow limiting transfers from/to a single branch We say that you cannot limit transfers internally within a branch, but it seems we do allow you to, and don't show you when we do To test: 1 - Go to Admin->Library transfer limits 2 - On a branches page, uncheck the box for that branch e.g. don't allow FIC to transfer to CPL from CPL 3 - Save 4 - Note the box is still checked 5 - Check the DB SELECT * FROM branch_transfer_limits; 6 - There is a line to/from CPL! 7 - Apply patches 8 - updatedatabase 9 - Repeat 5 - the line is deleted! 10 - Try to create the rule again, not the box is now disabled 11 - Be sneaky, enable the box, uncheck it and save, no rule created 12 - Be sneaky, edit the HMTL for another button to make it limiting CPL to CPL, save, no rule created 13 - Sign off Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Works as described. One note about p. 12. No rule where created when I change TPL to CPL in proper checkbox attribute "name". But then rule for TPL was created, probably as effect of compare lists: (1) branches from DB and (2) branches from form. TPL was not present in form (changed to CPL), so TPL (used from list of branches) was treated as "unchecked" => "not allowed" and rule was created. [ branch_transfer_limits.pl line ~70 ] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 193629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193629&action=edit Bug 41131: Don't allow limiting transfers from/to a single branch We say that you cannot limit transfers internally within a branch, but it seems we do allow you to, and don't show you when we do To test: 1 - Go to Admin->Library transfer limits 2 - On a branches page, uncheck the box for that branch e.g. don't allow FIC to transfer to CPL from CPL 3 - Save 4 - Note the box is still checked 5 - Check the DB SELECT * FROM branch_transfer_limits; 6 - There is a line to/from CPL! 7 - Apply patches 8 - updatedatabase 9 - Repeat 5 - the line is deleted! 10 - Try to create the rule again, not the box is now disabled 11 - Be sneaky, enable the box, uncheck it and save, no rule created 12 - Be sneaky, edit the HMTL for another button to make it limiting CPL to CPL, save, no rule created 13 - Sign off Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- add release notes, please! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branch Transfer Limits |Libaray transfer limits |basic editor allows one to |basic editor allows one to |prevent transfers from a |prevent transfers from a |library to itself and block |library to itself and block |related holds |related holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41131 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org