[Bug 41316] New: Using patron-homelibrary option for overdue notices does not change which rules are used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Bug ID: 41316 Summary: Using patron-homelibrary option for overdue notices does not change which rules are used Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Bug 32740 added an option to send overdue notices from the patrons home library, saying: When it's selected notification messages for overdues will be bundled and sent from the borrowing user's home library However, the other two options 'item homelibrary' and 'checkout library' also change which set of triggers are used. Currently the patron option will continue to use the triggers of the checkout library This is confusing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |41315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41315 [Bug 41315] Using patron-homelibrary option for overdue notices may not send notices to all branches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 189969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189969&action=edit Bug 41316: Use patrons homelibrary for selecting overdues that should be sent Currently the patron homelibrary option for OverdueNoticeFrom will select overdues for a branches triggers based on the issuing branch The other two options select the trigger/overdues based on the selection This patch alters the selection of overdues to match only for the patrons branch To test: 1 - Apply 41315 and follow the plan there 2 - Apply this bug and run the overdues script, assuming CPL is branch A: perl misc/cronjobs/overdue_notices.pl --triggered --library CPL --test --nomail -v -v 3 - No overdues should be triggered 4 - Run the script for one of the patrons home libraries, in my case MPL perl misc/cronjobs/overdue_notices.pl --triggered --library MPL --test --nomail -v -v 5 - Note only overdues for patrons from that branch are triggered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189969|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190953&action=edit Bug 41316: Use patrons homelibrary for selecting overdues that should be sent Currently the patron homelibrary option for OverdueNoticeFrom will select overdues for a branches triggers based on the issuing branch The other two options select the trigger/overdues based on the selection This patch alters the selection of overdues to match only for the patrons branch To test: 1 - Apply 41315 and follow the plan there 2 - Apply this bug and run the overdues script, assuming CPL is branch A: perl misc/cronjobs/overdue_notices.pl --triggered --library CPL --test --nomail -v -v 3 - No overdues should be triggered 4 - Run the script for one of the patrons home libraries, in my case MPL perl misc/cronjobs/overdue_notices.pl --triggered --library MPL --test --nomail -v -v 5 - Note only overdues for patrons from that branch are triggered Signed-off-by: Ben Daeuber <bdaeuber@fargolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190953|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 194096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194096&action=edit Bug 41316: Use patrons homelibrary for selecting overdues that should be sent Currently the patron homelibrary option for OverdueNoticeFrom will select overdues for a branches triggers based on the issuing branch The other two options select the trigger/overdues based on the selection This patch alters the selection of overdues to match only for the patrons branch To test: 1 - Apply 41315 and follow the plan there 2 - Apply this bug and run the overdues script, assuming CPL is branch A: perl misc/cronjobs/overdue_notices.pl --triggered --library CPL --test --nomail -v -v 3 - No overdues should be triggered 4 - Run the script for one of the patrons home libraries, in my case MPL perl misc/cronjobs/overdue_notices.pl --triggered --library MPL --test --nomail -v -v 5 - Note only overdues for patrons from that branch are triggered Signed-off-by: Ben Daeuber <bdaeuber@fargolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41316 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org