[Bug 34393] New: Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Bug ID: 34393 Summary: Inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the MARC bibliographic frameworks page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add bibliographic? (MARC bibliographic frameworks) - Change Add framework to New framework - Change 'Modify framework text' to "Modify framework 'frameworkcode'" - Change 'Delete framework for 'frameworkname' (frameworkcode)?" to "Confirm deletion of 'frameworkname' (framework code)" - Add a level for when viewing the MARC structure of a framework "MARC framework for 'frameworkname' (framework code)" (or MARC structure for... ?) - Change 'Add tag' to 'New tag' (? this one might work since we're adding *to* the framework? If we keep 'Add' we should change the button, so it matches) - When adding a tag, add a level for the framework - When viewing/editing subfields, add a level for the framework - When editing subfields, change 'Edit MARC subfields constraints' to "Modify MARC subfields constraints" (and add the tag number? "Modify MARC subfields constraints for tag 020") Breadcrumb - Add bibliographic? (MARC bibliographic frameworks) - Change Add framework to New framework - Change 'Delete framework for 'frameworkname' (frameworkcode)?" to "Confirm deletion of 'frameworkname' (framework code)" - When viewing the MARC structure of a framework, change "Frameworkname (frameworkcode)" to "MARC framework for 'frameworkname' (framework code)" (or MARC structure for... ?) - Change 'Add tag' to 'New tag' (? this one might work since we're adding *to* the framework? If we keep 'Add' we should change the button, so it matches) - When viewing subfields, the level for the framework should be "MARC framework for 'frameworkname' (framework code)", so it's consistent if we click on it - When viewing subfields, correct capitalization (Tag 010 Subfield structure to Tag 010 subfield structure) - When editing subfields, change 'Edit MARC subfields constraints' to "Modify MARC subfields constraints" (and add the tag number? "Modify MARC subfields constraints for tag 020") Page header - Add bibliographic? (MARC bibliographic frameworks) - Change Add framework to New framework - Change 'Delete framework for 'frameworkname' (frameworkcode)?" to "Confirm deletion of 'frameworkname' (framework code)" - When viewing the MARC structure of a framework, change 'Framework' to 'framework' (capitalization) (or change to MARC structure for... ?) - Change 'Add tag' to 'New tag' (? this one might work since we're adding *to* the framework? If we keep 'Add' we should change the button, so it matches) - When viewing subfields, remove 'admin' from the page header - When editing subfields, change 'Tag 020 Subfield constraints' to "Modify MARC subfields constraints for tag 020" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This one was a bit harder since there are so many pages... I might have forgotten something. Also, in this section, we use "frameworkname (frameworkcode)", as opposed to only the code. Personally I prefer have the name since sometimes the code isn't very telling. Maybe we should do the same for other sections (e.g. "Modify library Centerville (CPL)". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156506&action=edit Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header This patch fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The file admin/marc_subfields_structure.pl is modified so that it provides the framework name to the template. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - MARC bibliographic frameworks - New framework - Edit framework - Delete a framework which is not used - Delete a framework which is in use - Framework MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156506|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 156511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156511&action=edit Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header This patch fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The file admin/marc_subfields_structure.pl is modified so that it provides the framework name to the template. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - MARC bibliographic frameworks - New framework - Edit framework - Delete a framework which is not used - Delete a framework which is in use - Framework MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some release notes| |inconsistencies in the MARC | |bibliographic framework | |administration page, making | |sure the page title, | |breadcrumb navigation, and | |page headers are consistent | |with each other. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I've signed off, but there were two that I wasn't sure of. 1. View subfield constraints ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Tab title: Tag 006 > Books, Booklets, Workbooks (BKS) > MARC bibliographic frameworks > Administration > Koha Breadcrumb: Administration > MARC bibliographic frameworks > Books, Booklets, Workbooks (BKS) > Tag 006 subfield structure Page title: Tag 006 subfield structure (framework BKS) Comment: maybe the tab title should be 'Tag XXX subfield structure'? 2. Edit subfield constraints ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Tab title: Edit subfields constraints > Tag 006 > Books, Booklets, Workbooks (BKS) > MARC bibliographic frameworks > Administration > Koha Breadcrumb: Administration > MARC bibliographic frameworks > Books, Booklets, Workbooks (BKS) > Tag 006 > Edit subfields constraints Page title: Tag 006 subfield constraints Comment: I don't know why, but 'subfields constraints' seems wrong to me. There could be multiple subfields, with each of them having constraints. But it just sounds wrong to me... So I prefer 'Tag 006 subfield constraints'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156521&action=edit Bug 34393: (follow-up) QA fixes and further refinement This patch addresses issues discovered during testing and fixes a couple of issues which were missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156511|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156585&action=edit Bug 34393: Fix inconsistencies in MARC bibliographic framework page titles, breadcrumbs, and header This patch fixes some inconsistencies in the MARC bibliographic framework administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. The file admin/marc_subfields_structure.pl is modified so that it provides the framework name to the template. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - MARC bibliographic frameworks - New framework - Edit framework - Delete a framework which is not used - Delete a framework which is in use - Framework MARC structure - New tag - Edit tag - Delete tag - View subfields - Edit subfields Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156521|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156586&action=edit Bug 34393: (follow-up) QA fixes and further refinement This patch addresses issues discovered during testing and fixes a couple of issues which were missed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org