[Bug 34390] New: Inconsistencies in Credit types page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Bug ID: 34390 Summary: Inconsistencies in Credit types page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Credit types page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add credit type code to Modify X (e.g. Modify credit type 'CREDIT') Breadcrumb - Add credit type code to Modify X (e.g. Modify credit type 'CREDIT') Page header - Change 'Modify a credit type' to "Modify credit type 'Y'" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156458&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 156467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156467&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 156468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156468&action=edit Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a couple of release notes| |inconsistencies in the | |credit types administration | |page, making sure the page | |title, breadcrumb | |navigation, and page | |headers are consistent with | |each other. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Feel free to obsolete my follow-up patch - bug 34389 (debit types) and bug 34391 (cash registers) had single quotes around the debit and cash register code values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156458|0 |1 is obsolete| | Attachment #156467|0 |1 is obsolete| | Attachment #156468|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156496&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156497&action=edit Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156467|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156467|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156676&action=edit Bug 34390: Fix inconsistencies in credit types titles, breadcrumbs, and header Fix inconsistencies in credit types titles, breadcrumbs, and header This patch fixes a couple of inconsistencies in the credit types administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. To test, apply the patch and go to Administration -> Credit types. Test each variation of the page: - Main page - New credit type - Modify credit type Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156497|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156677&action=edit Bug 34390: (follow-up) Add single quotes around credit type For consistency with other bugs - adds single quotes around the credit type code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org