https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66679&action=edit Bug 19231: Add number of attached items to confirm message when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves and create 3 new courses 3) Add one item to a course, add two items to another course, and add no items to the third course 4) Delete the course with no items. Confirm the error message shows up. No need to say how many attached items there are here (because there are none). 5) Delete the course with one item. Confirm the error message shows and warns of the one attached item and makes grammatical sense 6) Delete the course with two items. Confirm the error message shows and shows the correct number of attached items and makes grammatical sense 7) Confirm clicking 'Cancel' and 'OK' does what is expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Hi Aleisha, I only got the normal warning message, but didn't get any information about the number of items attached. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 67069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67069&action=edit showing expected warning pop up (In reply to Claire Gravely from comment #2)

Hi Aleisha, I only got the normal warning message, but didn't get any information about the number of items attached.

(In reply to Dominic Pichette from comment #3)

I followed the steps and go the same results as Claire did. No error messages, only the normal warning were shown, none specified the items attached to the course.

Thank you both for testing, sorry I wasn't clear in my test plan. The normal warning pop up should be what shows, not an error message, that was my mistake. However, for courses that have more than one item in course, there should be an extra sentence in the warning, such as in the screenshot attached. I have tested and it is showing for me. Could you please test again? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66679|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 67071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67071&action=edit Bug 19231: Add number of attached items to confirm message when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves and create 3 new courses 3) Add one item to a course, add two items to another course, and add no items to the third course 4) Delete the course with no items. Confirm the error message shows up. No need to say how many attached items there are here (because there are none). 5) Delete the course with one item. Confirm the error message shows and warns of the one attached item and makes grammatical sense 6) Delete the course with two items. Confirm the error message shows and shows the correct number of attached items and makes grammatical sense 7) Confirm clicking 'Cancel' and 'OK' does what is expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Looks good! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67071|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68726&action=edit Bug 19231: Add number of attached items to confirm message when deleting course To test: 1) Ensure UseCourseReserves is enabled 2) Go to Course Reserves and create 3 new courses 3) Add one item to a course, add two items to another course, and add no items to the third course 4) Delete the course with no items. Confirm the error message shows up. No need to say how many attached items there are here (because there are none). 5) Delete the course with one item. Confirm the error message shows and warns of the one attached item and makes grammatical sense 6) Delete the course with two items. Confirm the error message shows and shows the correct number of attached items and makes grammatical sense 7) Confirm clicking 'Cancel' and 'OK' does what is expected Sponsored-by: Catalyst IT Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Looks good! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.