[Bug 19212] New: Warns when asking for a discharge OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Bug ID: 19212 Summary: Warns when asking for a discharge OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org To reproduce: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns: Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/opac/opac-discharge.pl line 50. Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/opac/opac-discharge.pl line 62. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 66660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66660&action=edit Bug 19212: Preventing warns when asking for discharge To test: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns 5) Apply patch and refresh page 6) Notice warns are gone Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aleisha@catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Hi Aleisha, I was unable to replicate the warns. When asking for a discharge I am just told it will be avealable in a few days without any errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- (In reply to Claire Gravely from comment #2)
Hi Aleisha,
I was unable to replicate the warns. When asking for a discharge I am just told it will be avealable in a few days without any errors.
I can confirm the warnings (in plack-error.log) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66660|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 67081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67081&action=edit Bug 19212: Preventing warns when asking for discharge To test: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns 5) Apply patch and refresh page 6) Notice warns are gone Sponsored-by: Catalyst IT Warnings reproduced in plack-error.log, with patch they are gone. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67081|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68727&action=edit Bug 19212: Preventing warns when asking for discharge To test: 1) Ensure the useDischarge syspref is enabled 2) Log in to OPAC 3) Go to 'ask for a discharge' 4) Notice warns 5) Apply patch and refresh page 6) Notice warns are gone Sponsored-by: Catalyst IT Warnings reproduced in plack-error.log, with patch they are gone. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org