https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43671 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 207063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207063&action=edit Bug 43671: Search for waiting holds instead of looping manually sco-main.pl had a while loop for the sole purpose of looping through all the patron's holds just to count how many were waiting. We should use the ->search function to identify waiting holds instead and let the DBI optimize the search. To test: 1. Apply patch and restart services 2. Have a patron with at least one pending hold, and no holds waiting 3. Open the SCO module in a private window: /cgi/bin/sco/sco-main.pl 4. Log into the SCO module as the patron from step 2 -->Confirm the holds tab shows the total number of the patron's holds and no additional icons 6. Click "Finish" 7. In the staff interface, check in an item at the pickup branch to set one of the patron's holds to Waiting 8. Log back into the SCO module as that patron --> Confirm the holds tab now has an (!) icon to indicate the patron has at least one waiting hold Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.