[Bug 23732] New: Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Bug ID: 23732 Summary: Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 95435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95435&action=edit Bug 23732: Hold rules checker == Test plan == - apply - yarn build - generate translations - try to place a hold, on the Hold details page you should see a "Holding rules" blue button - click it - check that the info if consistent with the holding rules, the syspref and the current and future number of holds of the patron - place the hold - set maxreserves syspref to 1 - try to place a hold - see in the holds rules checker that the maxreserves is highlighted in red (it the only thing supporting highlighting) - restore maxreserves syspref - test that sabotaging the matched circulation rule or hold policy is reflected (the limits) in the hold rules checker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #2 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 95436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95436&action=edit Bug 23732: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #3 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 95443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95443&action=edit Screen capture - Check this out :) Screen capture of our nice hold rules checker tool :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 95444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95444&action=edit Screen capture - position of "hold rule checker" button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95436|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 95445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95445&action=edit Bug 23732: Add unit tests == test plan == 1. prove -r t/db_dependent/Reserves 2. Apply bugzilla 3. prove t/db_dependent/Reserves/HoldRulesChecker.t 4. prove -r t/db_dependent/Reserves -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #6 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- screenshots: Not that "Check this out" is the name of the record. A very great also not so great name for examples ^_^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- *Note that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Overall this looks really good--and really useful! I see a few instances of "TODO" in the changes. Are these things which need a follow-up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Indeed I spotted these, I though I had fixed these but can't find the commit anywhere :o Planned to take care of these, at the same time of 18.11.x rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 95934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95934&action=edit Bug 23732: Renamed TODOs and added translation capabilities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- When backporting on 18.11 I got this error (when only circulation used): Template process failed: undef error - Can't call method "description" on an undefined value at /home/koha/src/Koha/Template/Plugin/Categories.pm line 33. To debug with : https://wiki.koha-community.org/wiki/User:Victor_Grousset_-_tuxayo:Debugging... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry, conflicts CONFLICT (content): Merge conflict in reserve/request.pl CONFLICT (content): Merge conflict in C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|victor@tuxayo.net |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|arthur.suzuki@biblibre.com |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/tuxayo/K | |oha/-/tree/hold-rules-check | |er-master/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95435|0 |1 is obsolete| | Attachment #95445|0 |1 is obsolete| | Attachment #95934|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 147501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147501&action=edit Bug 23732: Hold rules checker Test plan: - apply patch - try to place a hold, on the Hold details page you should see a "Holding rules" button. Click on it - check that the info is consistent with the holding rules, the syspref and the current and future number of holds of the patron - place the hold - set maxreserves syspref to 1 - try to place a hold - see in the holds rules checker that the maxreserves is highlighted in red - restore maxreserves syspref - test that sabotaging the matched circulation rule or hold policy is reflected in the hold rules checker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Attachment #95443|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 147504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147504&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Trying to revive this bug. There is one significant change: instead of a single circulation rule, the modal now shows all circulation rules that have been checked, in the order they have been checked. So if no hold is possible, the last rule should be the culprit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- I tested with "On shelf holds allowed" set to "If all unavailable" and the modal didn't give that as a reason why. Are there some rules which are not checked by this feature? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #17 from Laurence Rault <laurence.rault@biblibre.com> --- Tried to test on sandbox biblibre : When I choose a borrower during the hold process, it fails with : Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1570 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Owen Leonard from comment #16)
I tested with "On shelf holds allowed" set to "If all unavailable" and the modal didn't give that as a reason why. Are there some rules which are not checked by this feature?
Unfortunately yes. Only the rules checked by CanBookBeReserved are displayed. The 'on shelf holds' rule is checked in IsAvailableForItemLevelRequest so it's not displayed. I don't know how to fix that without a significant rewrite... :/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Laurence Rault from comment #17)
Tried to test on sandbox biblibre : When I choose a borrower during the hold process, it fails with : Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 1570
This error is not caused by this patch. I will open a new bug report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> ---
I will open a new bug report => Bug 33166
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED Depends on| |33166 CC| |koha@univ-lyon3.fr Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33166 [Bug 33166] Can't call method "notforloan" on an undefined value when placing a hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35195 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Depends on|33166 | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Reverting status from BLOCKED to Needs Signoff and removing bug 33166 from the "Depends on" list Bug 33166 is a different bug that has nothing to do with this bug Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33166 [Bug 33166] Item type database fields should not be nullable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catrina@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #22 from Esther Melander <esther.melander@bywatersolutions.com> --- Followed the test plan from comment 13. Nothing happens when clicking on the circulation rules link. My pop-up blocker was off, so nothing in the browser should have prevented it from appearing. Would it be possible to change the link to a button and have it be a bit bigger? It took a minute for me to see and realize that was clickable text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147501|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 173427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173427&action=edit Bug 23732: Hold rules checker Test plan: - apply patch - try to place a hold, on the Hold details page you should see a "Holding rules" button. Click on it - check that the info is consistent with the holding rules, the syspref and the current and future number of holds of the patron - place the hold - set maxreserves syspref to 1 - try to place a hold - see in the holds rules checker that the maxreserves is highlighted in red - restore maxreserves syspref - test that sabotaging the matched circulation rule or hold policy is reflected in the hold rules checker Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> Co-authored-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Rebased-by: Julian Maurice <julian.maurice@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 173428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173428&action=edit Bug 23732: Fixes for Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #25 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks a lot Julian for the earlier rebase!!! :o I had started locally a while ago but never got to catch up with main. Here is another rebase and basic Bootstrap 5 fixes. Testing was very superficial given I just found about those Bootstrap 5 changes that made the modal not open at all ^^" I'll try to check the rest soonish. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Esther Melander from comment #22)
Followed the test plan from comment 13. Nothing happens when clicking on the circulation rules link. My pop-up blocker was off, so nothing in the browser should have prevented it from appearing.
Would it be possible to change the link to a button and have it be a bit bigger? It took a minute for me to see and realize that was clickable text.
Thanks for trying to test. I suppose you where trying on a sandbox. So the old patches weren't applying and on sandbox creation it's not shown when that happens. That an unfortunate pitfall of the current sandbox UI, more detail in «Bug number: Don't fill it» https://wiki.koha-community.org/wiki/Sandboxes#Step_1:_Set_up_a_sandbox It's not ready yet for retesting, I'll notify when it is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173427|0 |1 is obsolete| | --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 178886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178886&action=edit Bug 23732: Hold rules checker Test plan: - apply patch - try to place a hold, on the Hold details page you should see a "Holding rules" button. Click on it - check that the info is consistent with the holding rules, the syspref and the current and future number of holds of the patron - place the hold - set maxreserves syspref to 1 - try to place a hold - see in the holds rules checker that the maxreserves is highlighted in red - restore maxreserves syspref - test that sabotaging the matched circulation rule or hold policy is reflected in the hold rules checker Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> Co-authored-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Rebased-by: Julian Maurice <julian.maurice@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173428|0 |1 is obsolete| | --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 178887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178887&action=edit Bug 23732: Fixes for Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #29 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased. After some testing it seems it's working. There is still UI work to make the rules readable when there are multiple items. Otherwise the following would be very hard to guess: (In reply to Julian Maurice from comment #15)
So if no hold is possible, the last rule should be the culprit.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #30 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 178888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178888&action=edit Multiple items, holds_per_record ok, holds_per_day ok, reservesallowed blocking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178888|Multiple items, |Screenshot: Multiple items, description|holds_per_record ok, |holds_per_record ok, |holds_per_day ok, |holds_per_day ok, |reservesallowed blocking |reservesallowed blocking -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178886|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178887|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173427|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173428|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #31 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Victor Grousset/tuxayo from comment #29)
Rebased. After some testing it seems it's working.
The hold rules checker seems to be working. However, the patches contained tons of related changes due to an error when running the auto_rebase script. So likely broke other stuff while miraculously having the hold rules checker working. I'll keep digging into this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173427|0 |1 is obsolete| | --- Comment #32 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 179026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179026&action=edit Bug 23732: Hold rules checker Test plan: - apply patch - try to place a hold, on the Hold details page you should see a "Holding rules" button. Click on it - check that the info is consistent with the holding rules, the syspref and the current and future number of holds of the patron - place the hold - set maxreserves syspref to 1 - try to place a hold - see in the holds rules checker that the maxreserves is highlighted in red - restore maxreserves syspref - test that sabotaging the matched circulation rule or hold policy is reflected in the hold rules checker Co-authored-by: Victor Grousset/tuxayo <victor@tuxayo.net> Co-authored-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Rebased-by: Julian Maurice <julian.maurice@biblibre.com> Co-authored-by: Julian Maurice <julian.maurice@biblibre.com> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173428|0 |1 is obsolete| | --- Comment #33 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 179027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179027&action=edit Bug 23732: Fixes for Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Amended the patches to be compliant with 38714, that was breaking the auto_rebase script. I'll retry and compare the diff and retest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org