http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #6 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 45847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45847&action=edit Bug 14658 - (QA followup) make it easier to grep for these syspref names -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #8 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #7)

Should not we display the value (readonly) if it exists?

While this could be useful, I think it'd be surprising behavior given how the syspref currently works. Also, the bugs chaining off of this to allow patrons to enter their category or home library show up as readonly for existing patrons anyway (as you wouldn't want a patron to randomly change their library/category). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43041|0 |1 is obsolete| | Attachment #45847|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46074&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers <msauers@dospace.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46074|0 |1 is obsolete| | --- Comment #11 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46235&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers <msauers@dospace.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46235|0 |1 is obsolete| | --- Comment #13 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46237&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers <msauers@dospace.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #15 from Jesse Weaver <jweaver@bywatersolutions.com> --- Sorry for spam, accidentally obliterated Joubu's signoffs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #16 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46352&action=edit Bug 14658: (followup) fix issue with list context on DBIC call While working on bug 14659, it was discovered that the call to ...->guarantor in list context will cause the hash to be misaligned (thus causing hidden => ... to not actually be sent to the template). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #18 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #17)

(In reply to Jesse Weaver from comment #16)

...

Created attachment 46352 [details] [review] [review] Bug 14658: (followup) fix issue with list context on DBIC call

While working on bug 14659, it was discovered that the call to ...->guarantor in list context will cause the hash to be misaligned (thus causing hidden => ... to not actually be sent to the template).

Could you move that to another bug report, to make it backportable to stable branches?

I could, but this error doesn't really cause any issues unless you add something else to that $template->param call, which is only likely from an another enhancement. Not much benefit from backporting, in my opinion. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #20 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Owen Leonard from comment #19)

(In reply to Jesse Weaver from comment #16)

...

Created attachment 46352 [details] [review] [review] Bug 14658: (followup) fix issue with list context on DBIC call

Is this bug set to 'needs signoff' because of this follow-up? If so, is there a test plan for the follow-up?

The followup was introduced to fix a bug caused by a change in master since this patch was originally submitted; the test plan should be the same as before. -- You are receiving this mail because: You are watching all bug changes.