[Bug 15343] New: Allow patrons to choose their own password on self registration.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Bug ID: 15343 Summary: Allow patrons to choose their own password on self registration. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently patron passwords are auto-generated and a patron must either immediately log in to change their password and/or record them. This patch would simply allow the patron to create their password during registration. Work to be done: * Extend AddMember_Opac to allow passing in the password. * Add update to make password field hidden by default. * Add password/confirm password fields and relevant error messages to opac-memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Sally Healey <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 45861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45861&action=edit Bug 15343 - Allow user to set password on opac-memberentry.pl This patch allows patrons to create thier own password during OPAC self registration. It sets the password field to be hidden by default, and allows for a system generated password if no password is supplied and field is not mandatory 1 - Apply patch 2 - run updatedatabase.pl 3 - Check syspref "PatronSelfRegistrationBorrowerUnwantedField" - it should contain 'password' 4 - Check self registration on opac - there should be no change 5 - Remove 'password' from PatronSelfRegistrationBorrowerUnwantedField 6 - Password field should now be visible in OPAC self registration 7 - Register a patron: If no passwor is supplied you should get a system generated password 8 - Register a patron with a password, your password should be used 9 - Add 'password' to PatronSelfRegistrationBorrowerMnadatoryField 10 - Attempt to register a patron with no password - it should fail 11 - Try all combinations if mismatched/short/missing passwords and view correct error messages 12 - prove t/db_dependent/Members.t Sponsored by : Do Space (www.dospace.org) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45866&action=edit Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45866|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45867&action=edit Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45867|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45868&action=edit Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45868|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 45869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45869&action=edit Bug 15343 [QA Followup] - Fix issues 1) "Contact information" should be "Password" 2) Don't pass sysprefs from the script to the template, use Koha.Preference() 3) minPasswordLength is optional, we cannot always assume it is set 4) Password field when does not follow convention completely when mandatory Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com, | |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Needs Signoff |Failed QA --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- With this patch, the verification box doesn't show, and you cannot complete a self registration. You will always get the message "You typed in the wrong characters in the box before submitting. Please try again." I like the idea of this though. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Hi Liz, I tested in Firefox and Chrome and could not recreate this issue, can you check again? Moving back to Needs Signoff -Nick -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Liz Rea from comment #7)
With this patch, the verification box doesn't show, and you cannot complete a self registration. You will always get the message "You typed in the wrong characters in the box before submitting. Please try again."
Same for me. Iceweasel 38.5.0 and Chromium 47.0.2526.80 on Debian. Here are my settings: PatronSelfRegistration - "Allow" PatronSelfRegistrationAdditionalInstructions - Empty PatronSelfRegistrationBorrowerMandatoryField - surname|firstname PatronSelfRegistrationBorrowerUnwantedField - password PatronSelfRegistrationDefaultCategory - T PatronSelfRegistrationExpireTemporaryAccountsDelay - 14 PatronSelfRegistrationVerifyByEmail - Require -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 46705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46705&action=edit Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #1)
8 - Register a patron with a password, your password should be used
At this step I'm getting an error: DBIx::Class::Row::store_column(): No such column 'password2' on Koha::Schema::Result::BorrowerModification at /home/oleonard/kohaclone/Koha/Borrower/Modifications.pm line 65 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46705|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 46737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46737&action=edit Bug 15343 [QA Follow up] Fix captcha display Make captcha visible even if password field is hidden Remove password confirmation field before submitting modification -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org