[Bug 23308] New: Contents of "OpacMaintenanceNotice" HTML escaped on display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Bug ID: 23308 Summary: Contents of "OpacMaintenanceNotice" HTML escaped on display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew.isherwood@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The OpacMaintenanceNotice syspref states that you can enter HTML for display, but this is being rendered using the "html" filter, resulting in a less than desirable result. It should be using the $raw filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |andrew.isherwood@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 91493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91493&action=edit Bug 23308: Change html to filter to $raw This patch changes the erroneous html filter to $raw Test plan: - Apply patch - Enter some HTML into the OpacMaintenanceNotice syspref - View the OPAC front page => TEST: Observe that the notice displays correctly and the HTML is not escaped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91493|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91500&action=edit Bug 23308: Change html to filter to $raw This patch changes the erroneous html filter to $raw Test plan: - Apply patch - Enter some HTML into the OpacMaintenanceNotice syspref - View the OPAC front page => TEST: Observe that the notice displays correctly and the HTML is not escaped Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Frédérik Chénier <frederik.chenier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91500|0 |1 is obsolete| | --- Comment #3 from Frédérik Chénier <frederik.chenier@inlibro.com> --- Created attachment 91501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91501&action=edit Bug 23308: Change html to filter to $raw This patch changes the erroneous html filter to $raw Test plan: - Apply patch - Enter some HTML into the OpacMaintenanceNotice syspref - View the OPAC front page => TEST: Observe that the notice displays correctly and the HTML is not escaped Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91501|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91515&action=edit Bug 23308: Change html to filter to $raw This patch changes the erroneous html filter to $raw Test plan: - Apply patch - Enter some HTML into the OpacMaintenanceNotice syspref - View the OPAC front page => TEST: Observe that the notice displays correctly and the HTML is not escaped Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: frederik chenier <frederik.chenier@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.03 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23308 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org