[Bug 22710] New: Return to the last advanced search link not filtering correctly in 18.11.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Bug ID: 22710 Summary: Return to the last advanced search link not filtering correctly in 18.11.x Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- in 18.11.x the 'Return to the last advanced search' link is broken. The opac-search template is using the uri filter when it should probably be using url -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 88036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88036&action=edit Attachment to Bug 22710 - Return to the last advanced search link not filtering correctly in 18.11.x Bug 22710: Return to the last advanced search link not filtering correctly in 18.11.x TEST PLAN: 1. from 18.11.x perform an advanced search. 2. from the results page click on the 'Return to the last advanced search' link. 3. Get a 404 errror. 4. Apply patch and repeat steps 1 and 2. 5. This time you should be returned to the advanced search page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune@bulac.fr --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Sorry Lucas... The sandbox you've requested is not ready. Some problems occurred applying patches from bug 22710: <h1>Something went wrong !</h1>Applying: Bug 22710: Return to the last advanced search link not filtering correctly in 18.11.x fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt). error: could not build fake ancestor Patch failed at 0001 Bug 22710: Return to the last advanced search link not filtering correctly in 18.11.x The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 22710 - Return to the last advanced search link not filtering correctly in 18.11.x 88036 - Attachment to Bug 22710 - Return to the last advanced search link not filtering correctly in 18.11.x For information : I noticed this bug in a 18.11.04 instance, but not on the sandbox I used before applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Séverine, Did you checkout the 18.11 branch before applying this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- the above comment is a mistake. this was never backported to 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Return to the last advanced |[18.11] Return to the last |search link not filtering |advanced search link not |correctly in 18.11.x |filtering correctly CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 91904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91904&action=edit Bug 22710: [18.11.x] Return to the last advanced search link not filtering correctly in 18.11.x Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Applies perfectly on 18.11.x - moving straight to PQA, another one-line patch fixing a bad bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22710 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org