[Bug 11431] New: Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Bug ID: 11431 Summary: Add additional sound options for warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: melissa@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would be nice if Koha had a library of sounds to choose from and then apply to various yellow box warnings. This should also include a page in the administration area where staff could choose which sound to be played for each action. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- I think we can do this in a fairly elegant way: 1) Identify all triggers of existing sounds 2) Strip out existing html for playing sounds 3) Make those existing sound-triggering dialogs with a class "audio-success", "audio-error" 4) Add a new "warning" sound 5) Add the class "audio-alert" to those dialogs that should trigger the new audio sound 6) Modify the header include to trigger the respective sound if an element with one of these classes is present on the page via jquery ( if soundon is enabled of course ) 7) Rename soundon to something more sensible ( eg UseSounds, UseAudioAlerts, etc ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- 8) Add three new system preferences to define urls to override these sounds with. If left empty, the default sounds will be used -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- In your idea, will sounds be activable independently ? For example, I would like to have a sound at check-out, but NOT at check-in. Or I would like to have a sound at check-in only if there's a hold. If everything is OK, I don't want any sound. Will it be possible ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #4 from Peggy Thrasher <p.thrasher@dover.nh.gov> --- I have just been asked to make only the "Not Checked Out" sound different from the other check in message sounds. Other libraries may want a different sound for "Item was lost, now found". Will your solution accommodate that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29030&action=edit Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29031&action=edit Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29032&action=edit Bug 11431 [3] - Add ability to customize the warning, action, and success sounds -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29033&action=edit Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29034&action=edit Bug 11431 [5] - Update sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29030|0 |1 is obsolete| | Attachment #29031|0 |1 is obsolete| | Attachment #29032|0 |1 is obsolete| | Attachment #29033|0 |1 is obsolete| | Attachment #29034|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29035&action=edit Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29036&action=edit Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29037&action=edit Bug 11431 [3] - Add ability to customize the warning, action, and success sounds -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29038&action=edit Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29039&action=edit Bug 11431 [5] - Update sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29119&action=edit Bug 11431 [6] - Add the ability to specify arbitarary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29119|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29120&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Paul Poulain from comment #3)
In your idea, will sounds be activable independently ? For example, I would like to have a sound at check-out, but NOT at check-in. Or I would like to have a sound at check-in only if there's a hold. If everything is OK, I don't want any sound. Will it be possible ?
Yes! The last patch in this series give you full control of what events trigger an audio alert! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Peggy Thrasher from comment #4)
I have just been asked to make only the "Not Checked Out" sound different from the other check in message sounds. Other libraries may want a different sound for "Item was lost, now found". Will your solution accommodate that?
Yep! See the comment above this one! Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29120|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29404&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29035|0 |1 is obsolete| | Attachment #29036|0 |1 is obsolete| | Attachment #29037|0 |1 is obsolete| | Attachment #29038|0 |1 is obsolete| | Attachment #29039|0 |1 is obsolete| | Attachment #29404|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29764&action=edit Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29765&action=edit Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29766&action=edit Bug 11431 [3] - Add ability to customize the warning, action, and success sounds -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29767&action=edit Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29768&action=edit Bug 11431 [5] - Update sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29769&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Heather Braum <hbraum@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum@nekls.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29764|0 |1 is obsolete| | --- Comment #26 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31145&action=edit [SIGNED OFF] Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29765|0 |1 is obsolete| | --- Comment #27 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31146&action=edit [SIGNED OFF] Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29766|0 |1 is obsolete| | --- Comment #28 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31147&action=edit [SIGNED OFF] Bug 11431 [3] - Add ability to customize the warning, action, and success sounds Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29767|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31148&action=edit [SIGNED OFF] Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29768|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31149&action=edit [SIGNED OFF] Bug 11431 [5] - Update sysprefs.sql Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29769|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31150&action=edit [SIGNED OFF] Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> All sounds seemed to work with different .ogg .mp3 .wav sound types in firefox and chrome. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- I like the idea of this feature very much, but I have to be honest I find the configuration system for this really confusing. I don't think it's very user-friendly to require that you enter data in a very specific format. What about offering a set of form fields where an arbitrary number of lines could be added: [ jquery selector ] [ dropdown of existing media files ] - or - [ path to remote file] You might even be able to roll all of the preferences (except the "enable" one) into such a system if you included the defaults as choices under [ jquery selector]. I'm also curious about the possible performance hit the staff client takes by processing these DOM checks on every page, especially in slower systems. However, I'm not sure what is the best way to test that. Sorry I know that's a lot to ask after so much time and effort was put into this patch, but I would really like to see a feature as easy to use as the options for choosing an item type image. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> --- The other thing I noticed when testing this was that it didn't seem that any defaults were honored. After applying the patch and running the update I didn't have any circulation alert sounds anymore. Does this require that I re-enter them? I didn't think so based on my examination of the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #33)
The other thing I noticed when testing this was that it didn't seem that any defaults were honored. After applying the patch and running the update I didn't have any circulation alert sounds anymore. Does this require that I re-enter them? I didn't think so based on my examination of the changes.
That is correct, you should have had the same default sound behavior as before. I'll have to re-test. Are you saying that you had sound alerts at all after patching and updating the db, or was it just a specific sound that was missing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Joel Sasse <jsasse@plumcreeklibrary.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsasse@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31145|0 |1 is obsolete| | Attachment #31146|0 |1 is obsolete| | Attachment #31147|0 |1 is obsolete| | Attachment #31148|0 |1 is obsolete| | Attachment #31149|0 |1 is obsolete| | Attachment #31150|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34637&action=edit Bug 11431 [1] - Replace existing system with no change in functionality This patch set adds the ability to select which sounds are used for Koha's audio alerts, and which elements trigger those audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Set the various OverrideAudioAlert preferences to different sounds 6) Retest, verify new sounds play 7) Add/remove selectors from the AudioAlertSelector system preferences 8) Observe the difference in audio alert behavior based on your selections Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34638&action=edit Bug 11431 [2] - Rename soundon to AudioAlerts, move to it's own preference section Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34639&action=edit Bug 11431 [3] - Add ability to customize the warning, action, and success sounds Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34640&action=edit Bug 11431 [4] - Add the ability to choose the elements that trigger an audio alert Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34641&action=edit Bug 11431 [5] - Update sysprefs.sql Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34642&action=edit Bug 11431 [6] - Add the ability to specify arbitrary audio alerts This patch further enhances our control over Koha audio alerts by allowing a library to specify custom audio events. A new system preference is added the combines the functions of the Selector and Override systems preferences in a list of selector:sound combinations. These definitions override the default sounds and thus gives the library a way to completely redefine what events trigger and audio alert, and what sounds are played! Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit the new AudioAlertsCustom system preference and enter the following: "body:contains('Check in message')": "IM_notification.ogg" 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> All sounds seemed to work with different .ogg .mp3 .wav sound types in firefox and chrome. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34643&action=edit Bug 11431 [7] - Add new table for audio alerts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34644&action=edit Bug 11431 [8] - Add audio alerts editor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34645&action=edit Bug 11431 [9] - Remove new system preferences that are no longer needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34637|0 |1 is obsolete| | Attachment #34638|0 |1 is obsolete| | Attachment #34639|0 |1 is obsolete| | Attachment #34640|0 |1 is obsolete| | Attachment #34641|0 |1 is obsolete| | Attachment #34642|0 |1 is obsolete| | Attachment #34643|0 |1 is obsolete| | Attachment #34644|0 |1 is obsolete| | Attachment #34645|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34646&action=edit Bug 11431 - Update database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34647&action=edit Add audio alerts to installer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34648&action=edit Bug 11431 - Update schema -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34649&action=edit Bug 11431 - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34646|0 |1 is obsolete| | Attachment #34647|0 |1 is obsolete| | Attachment #34648|0 |1 is obsolete| | Attachment #34649|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34650&action=edit Bug 11431 [1] - Update database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34651&action=edit Bug 11431 [2] - Add audio alerts to installer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34652&action=edit Bug 11431 [3] - Update schema -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34653&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #52 from Nick Clemens <nick@quecheelibrary.org> --- Applying: Bug 11431 [4] - Add additional sound options fatal: sha1 information is lacking or useless (Koha/Object.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11431 [4] - Add additional sound options When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11431-4---Add-additional-sound-options-7v_z2F.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #53 from Nick Clemens <nick@quecheelibrary.org> --- forgot the depends -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #54 from Nick Clemens <nick@quecheelibrary.org> --- Still can't test, after applying 13019 and 11431 OPAC functions but I cannot access any pages in staff client, I only get the error below: Software error: Template process failed: undef error - hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /home/nick/kohaclone/Koha/Template/Plugin/Koha.pm line 52. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #55 from Nick Clemens <nick@quecheelibrary.org> --- Was an issue with updatedatabase, cleared and tested on two different machines and worked in both Chrome and firefox with ogg, wav and mp3. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34650|0 |1 is obsolete| | --- Comment #56 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34717&action=edit [SIGNED OFF]Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34651|0 |1 is obsolete| | --- Comment #57 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34718&action=edit [SIGNED OFF]Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34652|0 |1 is obsolete| | --- Comment #58 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34719&action=edit [SIGNED OFF]Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34653|0 |1 is obsolete| | --- Comment #59 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34720&action=edit [SIGNED OFF]Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34717|0 |1 is obsolete| | Attachment #34718|0 |1 is obsolete| | Attachment #34719|0 |1 is obsolete| | Attachment #34720|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34864&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34865&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34866&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34867&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Add additional sound |[DEPENDS ON 13019] Add |options for warnings |additional sound options | |for warnings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34864|0 |1 is obsolete| | Attachment #34865|0 |1 is obsolete| | Attachment #34866|0 |1 is obsolete| | Attachment #34867|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35843&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35844&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35845&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35846&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #68 from paxed <pasi.kallinen@pttk.fi> --- (In reply to Kyle M Hall from comment #67)
Created attachment 35846 [details] [review]
Just wondering if http:// vs https:// matters for this: + // This is way faster than substring + if ( ! ( sound.charAt(4) == ':' && sound.charAt(5) == '/' && sound.charAt(6) == '/' ) ) { -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[DEPENDS ON 13019] Add |Add additional sound |additional sound options |options for warnings |for warnings | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to paxed from comment #68)
(In reply to Kyle M Hall from comment #67)
Created attachment 35846 [details] [review] [review]
Just wondering if http:// vs https:// matters for this:
+ // This is way faster than substring + if ( ! ( sound.charAt(4) == ':' && sound.charAt(5) == '/' && sound.charAt(6) == '/' ) ) {
Good catch, maybe a regex is much more appropriate here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jeremy Wellner <jwellner@stanwood.wednet.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwellner@stanwood.wednet.ed | |u --- Comment #70 from Jeremy Wellner <jwellner@stanwood.wednet.edu> --- Our libraries workflow would be greatly enhanced by getting this enhancement wrapped up and pushed for release. Can someone take some time to look at this again? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38547&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38548&action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- This does not apply. You should change the collate of the new table, remove the "soundon" occurrence in C4/UsageStats.pm. I am a bit concerned by the Koha::Template::Plugin::Koha::AudioAlerts subroutine, not sure it's the best place to put it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35843|0 |1 is obsolete| | Attachment #35844|0 |1 is obsolete| | Attachment #35845|0 |1 is obsolete| | Attachment #35846|0 |1 is obsolete| | Attachment #38547|0 |1 is obsolete| | Attachment #38548|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40726&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40727&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40728&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40729&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40730&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #79 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40731&action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #80 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40732&action=edit Bug 11431 - Update UsageStats.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #81 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comments: 1/ There are no tests for new modules 2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts moved somewhere else 3/ SyntaxError: missing ) after condition ndexOf('http://') == 0 || sound.indexOf('https://') == 0 ) { Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #82 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41634&action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41661&action=edit Bug 11431 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #84 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 41662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41662&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #85 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Kyle M Hall from comment #84)
Created attachment 41662 [details] [review] Bug 11431 [QA Followup] - Simplify audio_alert_id to just id
audio_alert_id is very wordy and it's a better convention to just give the table id the name 'id'. No changes in the code were needed since I was already using the id() method. Unit tests pass pre and post patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #86 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref CONFLICT (content): Merge conflict in Koha/Template/Plugin/Koha.pm (In reply to Jonathan Druart from comment #81)
2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts moved somewhere else
Still needs an answer. Are not you afraid that this plugin become a holdall? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40726|0 |1 is obsolete| | Attachment #40727|0 |1 is obsolete| | Attachment #40728|0 |1 is obsolete| | Attachment #40729|0 |1 is obsolete| | Attachment #40730|0 |1 is obsolete| | Attachment #40731|0 |1 is obsolete| | Attachment #40732|0 |1 is obsolete| | Attachment #41634|0 |1 is obsolete| | Attachment #41661|0 |1 is obsolete| | Attachment #41662|0 |1 is obsolete| | --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42678&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42679&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42680&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42681&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42682&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42683&action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42684&action=edit Bug 11431 - Update UsageStats.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42685&action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42686&action=edit Bug 11431 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42687&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42688&action=edit Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42689&action=edit Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #99 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Jonathan Druart from comment #86)
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_client.pref CONFLICT (content): Merge conflict in Koha/Template/Plugin/Koha.pm
Fixed!
(In reply to Jonathan Druart from comment #81)
2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts moved somewhere else
Still needs an answer. Are not you afraid that this plugin become a holdall?
I understand what you mean. Fixed! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #100 from Nick Clemens <nick@quecheelibrary.org> --- Tested just to confirm my sign off. Test plan works as expected. Minor bug: If you delete a sound alert, the preferences are not automatically renumbered and you get an error if you try to move another alert into the empty slot. To recreate: 1 - Add an alert (example in test plan works fine) 2 - Move it to priority 2 3 - Delete it 4 - Remaining alerts are preference 1,3,4 5 - Try to move #3 up one slot 6 - Receive error: Can't call method "precedence" on an undefined value at /home/nick/kohaclone/Koha/AudioAlerts.pm line 96. 7 - Back up, move alert number 3 to top (second arrow) 8 - Priorities are renumbered correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42696&action=edit Bug 11431 [QA Followup] - Fix alter precedences on delete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #102 from Kyle M Hall <kyle.m.hall@gmail.com> --- Thanks for catching that! Followup posted! (In reply to Nick Clemens from comment #100)
Tested just to confirm my sign off. Test plan works as expected.
Minor bug: If you delete a sound alert, the preferences are not automatically renumbered and you get an error if you try to move another alert into the empty slot.
To recreate: 1 - Add an alert (example in test plan works fine) 2 - Move it to priority 2 3 - Delete it 4 - Remaining alerts are preference 1,3,4 5 - Try to move #3 up one slot 6 - Receive error: Can't call method "precedence" on an undefined value at /home/nick/kohaclone/Koha/AudioAlerts.pm line 96. 7 - Back up, move alert number 3 to top (second arrow) 8 - Priorities are renumbered correctly
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply - please fix! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42678|0 |1 is obsolete| | Attachment #42679|0 |1 is obsolete| | Attachment #42680|0 |1 is obsolete| | Attachment #42681|0 |1 is obsolete| | Attachment #42682|0 |1 is obsolete| | Attachment #42683|0 |1 is obsolete| | Attachment #42684|0 |1 is obsolete| | Attachment #42685|0 |1 is obsolete| | Attachment #42686|0 |1 is obsolete| | Attachment #42687|0 |1 is obsolete| | Attachment #42688|0 |1 is obsolete| | Attachment #42689|0 |1 is obsolete| | Attachment #42696|0 |1 is obsolete| | --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43753&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43754&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43755&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43756&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #108 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43757&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43758&action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #110 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43759&action=edit Bug 11431 - Update UsageStats.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43760&action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #112 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43761&action=edit Bug 11431 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43762&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #114 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43763&action=edit Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43764&action=edit Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #116 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43765&action=edit Bug 11431 [QA Followup] - Fix alter precedences on delete -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #117 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, one small thing: If AudioAlerts is turned off the 'play' button on the administration page won't work and save the entry instead. That was quite confusing. I think independent of the AudioAlerts setting, you should be able to 'preview' the sounds on the admin page. The second best solution would be to not display the play button in this case. Enhancement ideas: - I'd really really like an option to play the sounds of saved entries for easier testing and also the option of editing the entries - if you get your selector wrong, it can be quite annoying to delete and start over. - Adding an example to the help page would be great. The example on the bug report is not quite so good, as it relies on the existence of an English string in a certain place and would be hard to translate, but maybe another example that is based on a class or id? Can you please take a look? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #118 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43817&action=edit Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43820&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #120 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43821&action=edit Bug 11431 [QA Followup] - Update help -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43820|0 |1 is obsolete| | Attachment #43821|0 |1 is obsolete| | --- Comment #121 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43822&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #122 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43823&action=edit Bug 11431 [QA Followup] - Update help -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43822|0 |1 is obsolete| | Attachment #43823|0 |1 is obsolete| | --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43824&action=edit Bug 11431 [QA Followup] - Update help -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #124 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43825&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43887&action=edit [PASSED QA] Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #126 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43888&action=edit [PASSED QA] Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43889&action=edit [PASSED QA] Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #128 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43890&action=edit [PASSED QA] Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #129 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43891&action=edit [PASSED QA] Bug 11431 [QA Followup] - Allow https in sound URLs Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #130 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43892&action=edit [PASSED QA] Bug 11431 [QA Followup] - Fix POD Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #131 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43893&action=edit [PASSED QA] Bug 11431 - Update UsageStats.pm Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #132 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43894&action=edit [PASSED QA] Bug 11431 [QA Followup] - Fix js error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #133 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43895&action=edit [PASSED QA] Bug 11431 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #134 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43896&action=edit [PASSED QA] Bug 11431 [QA Followup] - Simplify audio_alert_id to just id Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #135 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43897&action=edit [PASSED QA] Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #136 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43898&action=edit [PASSED QA] Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #137 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43899&action=edit [PASSED QA] Bug 11431 [QA Followup] - Fix alter precedences on delete Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #138 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43900&action=edit [PASSED QA] Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor page Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #139 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43901&action=edit [PASSED QA] Bug 11431 [QA Followup] - Update help Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #140 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43902&action=edit [PASSED QA] Bug 11431 [QA Followup] - Add ability to edit audio alerts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #141 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43903&action=edit Bug 11431: QA follow-up: Typo in help file / variable name Fixes the variable name to avoid a double-up that made it impossible to turn off the sounds in general. If AudioAlerts are turned off, they will only work on the audio administration page now so you can set up and test the different sounds there. Also fixes a little typo in the help file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #142 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44391&action=edit Bug 11431 [QA Followup] - Make audio alerts sql top level Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43887|0 |1 is obsolete| | Attachment #43888|0 |1 is obsolete| | Attachment #43889|0 |1 is obsolete| | Attachment #43890|0 |1 is obsolete| | Attachment #43891|0 |1 is obsolete| | Attachment #43892|0 |1 is obsolete| | Attachment #43893|0 |1 is obsolete| | Attachment #43894|0 |1 is obsolete| | Attachment #43895|0 |1 is obsolete| | Attachment #43896|0 |1 is obsolete| | Attachment #43897|0 |1 is obsolete| | Attachment #43898|0 |1 is obsolete| | Attachment #43899|0 |1 is obsolete| | Attachment #43900|0 |1 is obsolete| | Attachment #43901|0 |1 is obsolete| | Attachment #43902|0 |1 is obsolete| | Attachment #43903|0 |1 is obsolete| | Attachment #44391|0 |1 is obsolete| | --- Comment #143 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44392&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #144 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44393&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #145 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44394&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #146 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44395&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #147 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44396&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #148 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44397&action=edit Bug 11431 [QA Followup] - Fix POD Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #149 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44398&action=edit Bug 11431 - Update UsageStats.pm Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #150 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44399&action=edit Bug 11431 [QA Followup] - Fix js error Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #151 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44400&action=edit Bug 11431 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #152 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44401&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #153 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44402&action=edit Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #154 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44404&action=edit Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #155 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44405&action=edit Bug 11431 [QA Followup] - Fix alter precedences on delete Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #156 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44407&action=edit Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor page Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #157 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44408&action=edit Bug 11431 [QA Followup] - Update help Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #158 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44409&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #159 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44411&action=edit Bug 11431: QA follow-up: Typo in help file / variable name Fixes the variable name to avoid a double-up that made it impossible to turn off the sounds in general. If AudioAlerts are turned off, they will only work on the audio administration page now so you can set up and test the different sounds there. Also fixes a little typo in the help file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #160 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44412&action=edit Bug 11431 [QA Followup] - Make audio alerts sql top level Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #161 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Great job Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #162 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44599&action=edit Bug 11431: (QA followup) remove diags Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add additional sound |Custom sound alerts |options for warnings | Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Custom sound alerts |Custom notification sounds -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #163 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45135&action=edit Bug 11431: (follow-up) Update database This patch specifies the collate for the new audio_alerts table to the updatedb entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15207 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org