https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43865 Bug ID: 43865 Summary: Typo in item_inactive class on selected inactive item fund in addorderiso2709.tt Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Spotted while pushing Bug 43787. In koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt, the item-level fund dropdown renders an option that is both inactive and the item's currently selected fund with the class "buget_item_inactive" (typo: missing 'd'). All the other inactive item options use "budget_item_inactive". koha-tmpl/intranet-tmpl/prog/js/funds_sorts.js builds the "active funds only" dropdown by removing every ".budget_item_inactive" child from a clone of each item select. Because of the typo, the selected inactive fund is not removed, so it stays selected in the active-only dropdown. The typo was introduced by Bug 22712 and no CSS or other JS references either spelling. Do NOT simply correct the spelling: the selected inactive option would then be stripped from the active-only dropdown, the item would lose its existing fund in the visible select, and an empty budget_id would be submitted for it. Suggested approach: decide whether the selected inactive option should keep a class at all. Either drop the class from that option (no behaviour change), or give it an explicit, correctly named class (e.g. budget_item_selected_inactive) that funds_sorts.js deliberately leaves alone, and add a comment explaining why. Test plan: 1. Create an inactive budget with a fund and stage a MARC file whose items map to that fund (MarcItemFieldsToOrder). 2. Go to Add to basket > From a staged file and open the staged file. 3. Confirm the item's fund dropdown shows the inactive fund selected while 'Show inactive funds' is unchecked. 4. Toggle 'Show inactive funds' and confirm the selection is retained both ways. 5. After the fix, repeat and confirm behaviour is unchanged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.