https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dcook@prosentient.com.au, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |ByWater Solutions list of Sponsors| | Sponsorship status|--- |Sponsored Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200148&action=edit Bug 42405: Add REST API endpoints for single cover image operations This patch adds three REST API endpoints: POST /api/v1/biblios/{biblio_id}/cover_images POST /api/v1/items/{item_id}/cover_images DELETE /api/v1/cover_images/{image_id} These replace the svc/cover_images CGI script with proper REST endpoints. Upload endpoints accept an image via multipart/form-data and an optional replace query parameter. Test plan: 1. Apply patch 2. Regenerate the API bundle: $ ktd --shell k$ cd /kohadevbox/koha && yarn api:bundle 3. Run: k$ prove t/db_dependent/api/v1/cover_images_single.t => SUCCESS: Tests pass! 4. Tests cover: - Successful biblio image upload (201) - Multiple images without replace - Replace mode deletes existing images - Biblio not found (404) - Successful item image upload (201) - Item not found (404) - Delete image (204) - Delete non-existent image (404) 5. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42804 Attachment #200147|0 |1 is obsolete| | Attachment #200148|0 |1 is obsolete| | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42804 [Bug 42804] Replace svc/cover_images and tools/upload-cover-image.pl with REST API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200154&action=edit Bug 42405: Add REST API endpoints for single cover image operations This patch adds three REST API endpoints: POST /api/v1/biblios/{biblio_id}/cover_images POST /api/v1/items/{item_id}/cover_images DELETE /api/v1/cover_images/{image_id} These replace the svc/cover_images CGI script with proper REST endpoints. Upload endpoints accept an image via multipart/form-data and an optional replace query parameter. Test plan: 1. Apply patch 2. Regenerate the API bundle: $ ktd --shell k$ cd /kohadevbox/koha && yarn api:bundle 3. Run: k$ prove t/db_dependent/api/v1/cover_images_single.t => SUCCESS: Tests pass! 4. Tests cover: - Successful biblio image upload (201) - Multiple images without replace - Replace mode deletes existing images - Biblio not found (404) - Successful item image upload (201) - Item not found (404) - Delete image (204) - Delete non-existent image (404) 5. Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200153|0 |1 is obsolete| | Attachment #200154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 201136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201136&action=edit Bug 42405: Add REST API endpoints for single cover image operations This patch adds three REST API endpoints: POST /api/v1/biblios/{biblio_id}/cover_images POST /api/v1/items/{item_id}/cover_images DELETE /api/v1/cover_images/{image_id} These replace the svc/cover_images CGI script with proper REST endpoints. Upload endpoints accept an image via multipart/form-data and an optional replace query parameter. Test plan: 1. Apply patch 2. Regenerate the API bundle: $ ktd --shell k$ cd /kohadevbox/koha && yarn api:bundle 3. Run: k$ prove t/db_dependent/api/v1/cover_images_single.t => SUCCESS: Tests pass! 4. Tests cover: - Successful biblio image upload (201) - Multiple images without replace - Replace mode deletes existing images - Biblio not found (404) - Successful item image upload (201) - Item not found (404) - Delete image (204) - Delete non-existent image (404) 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201135|0 |1 is obsolete| | Attachment #201136|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 201318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201318&action=edit Bug 42405: Add REST API endpoints for single cover image operations This patch adds three REST API endpoints: POST /api/v1/biblios/{biblio_id}/cover_images POST /api/v1/items/{item_id}/cover_images DELETE /api/v1/cover_images/{image_id} These replace the svc/cover_images CGI script with proper REST endpoints. Upload endpoints accept an image via multipart/form-data and an optional replace query parameter. Test plan: 1. Apply patch 2. Regenerate the API bundle: $ ktd --shell k$ cd /kohadevbox/koha && yarn api:bundle 3. Run: k$ prove t/db_dependent/api/v1/cover_images_single.t => SUCCESS: Tests pass! 4. Tests cover: - Successful biblio image upload (201) - Multiple images without replace - Replace mode deletes existing images - Biblio not found (404) - Successful item image upload (201) - Item not found (404) - Delete image (204) - Delete non-existent image (404) 5. Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 --- Comment #11 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #10)

(In reply to David Nind from comment #7)

...

Testing notes (using KTD): 1. I did not manually test uploading cover images, I just ran the tests. 2. The qa script complains about tidyness: ... [FAIL] Koha/REST/V1/CoverImages.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/REST/V1/CoverImages.pm` ...

Please retest!

The qa script is happy now 8-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |lucas@bywatersolutions.com |o.uk | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This work adds the release notes| |following endpoints to the | |API: | | | |* `POST | |/api/v1/biblios/{biblio_id} | |/cover_images`: add a cover | |image to a bibliographic | |record. | |* `POST | |/api/v1/items/{item_id}/cov | |er_images`: add a cover | |image for an item | |* `DELETE | |/api/v1/cover_images/{image | |_id}`: remove a cover image | |from the system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42405 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209372&action=edit Bug 42405: (follow-up) Fix replace behaviour in single cover image endpoints POST /biblios/{biblio_id}/cover_images and POST /items/{item_id}/cover_images had two problems when replacing existing covers. They are the same Lucas reported for the batch import on bug 42404 comment #45: 1. Replacing a biblio's covers used $biblio->cover_images, which also includes the covers of its items, so the item level covers were deleted too. tools/upload-cover-image.pl only deleted the biblio level ones. 2. The AllowMultipleCovers system preference was ignored, so API consumers could attach several covers to a record when the library does not allow it. tools/upload-cover-image.pl always replaced existing covers when it was disabled. This patch only deletes the biblio level covers (itemnumber IS NULL) when replacing a biblio's covers, and replaces existing covers when AllowMultipleCovers is disabled, whatever the 'replace' parameter says. The logic is in a _replace_covers helper shared by both endpoints. The API spec documents the behaviour. This matches what bug 42404 does for the batch import. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ restart_all k$ prove t/db_dependent/api/v1/cover_images_single.t \ xt/api.t => SUCCESS: Tests pass! 3. Revert the changes to Koha/REST/V1/CoverImages.pm and repeat 2 => FAIL: Item level covers are deleted, and covers pile up with AllowMultipleCovers disabled 4. Restore the changes and restart services: k$ restart_all 5. Enable LocalCoverImages, AllowMultipleCovers and RESTBasicAuth 6. Go to record 1, and upload an image for one of its items (holdings table: Edit -> Upload image) 7. Upload a record cover, replacing existing ones: k$ curl -u koha:koha \ -F file=@/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/img/koha-logo.png \ "http://localhost:8081/api/v1/biblios/1/cover_images?replace=true" => SUCCESS: 201 with a cover_image_id 8. Go to record 1 => SUCCESS: The item cover uploaded in 6 is still there 9. Disable AllowMultipleCovers, repeat 7 twice without ?replace=true => SUCCESS: Record 1 has a single record level cover 10. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.