[Bug 14764] New: Add OPAC News branch selector
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Bug ID: 14764 Summary: Add OPAC News branch selector Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: xarragon@gmail.com QA Contact: testopia@bugs.koha-community.org When branch-specific news are added users can only view entries from their home branch and global ones. These patches adds a syspref, 'OPACNewsBranchSelect' that allows a list of branches to be displayed above the left OpacNav field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #1 from Martin Persson <xarragon@gmail.com> --- Created attachment 42129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42129&action=edit Bug 14764: OPAC news selector - URL parameter This patch adds an URL-based override for the homebranch variable in opac-main.pl. Allows viewing of arbitrary branches. Possible security issue: The user changes branch parameter to perform SQL or XSS injection. This would not be possible via the database, as the foreign key constraint would block arbitrary code. However, the News retrieval function is using prepared statements which are immune to this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #2 from Martin Persson <xarragon@gmail.com> --- Created attachment 42130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42130&action=edit Bug 14764: OPAC news selector - Template tags Adds tags to the template files to inject branch list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #3 from Martin Persson <xarragon@gmail.com> --- Created attachment 42131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42131&action=edit Bug 14764: OPAC news selector - Add syspref Adds the new system preference to the pref and SQL files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #4 from Martin Persson <xarragon@gmail.com> --- Created attachment 42132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42132&action=edit Bug 14764: OPAC news selector - Atomic update SQL Adds an SQL file to perform the database upgrade. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #5 from Martin Persson <xarragon@gmail.com> --- Created attachment 42139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42139&action=edit Bug 14764: OPAC news selector - Fix RSS feed Update opac-main RSS feed to match current branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from Martin Persson <xarragon@gmail.com> --- Test plan: 1) Add more libraries, at least two in total is needed. Make note of whoich is your current user's home branch. 2) Go to Tools -> News and add one global ("All") news item and one specific for each branch. 3) Apply the patches. 4) Perform database upgrades when you log in. 5) Go to OPAC main, it should work as before: Showing global news as well as the news for your home branch once logged in. 6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes. 7) Go to OPAC main, you should see the global news item plus any items for your home branch for the current user if logged in. 8) On the left side all branches should be listed as links. Select one, you should now see global news and the news for the selected branch, regardless of whether logged in or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42129|0 |1 is obsolete| | --- Comment #7 from Martin Persson <xarragon@gmail.com> --- Created attachment 42146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42146&action=edit Bug 14764: OPAC news selector - URL parameter This patch adds an URL-based override for the homebranch variable in opac-main.pl. Allows viewing of arbitrary branches. Possible security issue: The user changes branch parameter to perform SQL or XSS injection. This would not be possible via the database, as the foreign key constraint would block arbitrary code. However, the News retrieval function is using prepared statements which are immune to this. Changes: Parameter 'branch' renamed 'branchcode' Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42130|0 |1 is obsolete| | --- Comment #8 from Martin Persson <xarragon@gmail.com> --- Created attachment 42147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42147&action=edit Bug 14764: OPAC news selector - Template tags Adds tags to the template files to inject branch list. Changes: Fixed pref name, renamed branch to branchcode Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 --- Comment #9 from Martin Persson <xarragon@gmail.com> --- Apply the RSS fix last to avoid conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14305 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 [Bug 14305] Public way to look at the Opac of different branches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #10 from Martin Persson <xarragon@gmail.com> --- *** This bug has been marked as a duplicate of bug 14305 *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42146|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42139|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff --- Comment #11 from Martin Persson <xarragon@gmail.com> --- Retested this, discovered that this and patch 14305 overlapped in code to some extent. Set the other as a dependency and obsoleted the overlapping patches. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org