[Bug 14305] New: Public way to look at the Opac of different branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Bug ID: 14305 Summary: Public way to look at the Opac of different branches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: viktor.sarge@regionhalland.se QA Contact: testopia@bugs.koha-community.org We now have a way to target news to different branches. But as a patron you can only look at news for "all libraries" + when signed in "all libraries + your specific branch". Since news for specific branches seem like a thing that is obviously public information we need to create a way to display switch branch without registering for a new branch while logged in. I see two approaches: * Seeing news as a widget and switch branch while staying on the same page. This is easily solved with a drop down or something similar. * Add real navigation for switching branch. Since we now have unique identifiers for the body-tag in order to be able to brand each branch with a different CSS this might look like the natural order. (I do feel that the widget approach still have it's merits. I have seen some good consortia solutions where the starting page is the same for all and you load it with ajax components that can expose branch specific information like opening hours, searches etc. Any help in sorting out how to proceed is welcome.. I recall that there is a bug for a public calendar, and if you also take into account calendar, creating events that show up in both calendar and a separate news-flow, expanding CMS-functionality this might require some thinking) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #1 from Martin Persson <xarragon@gmail.com> --- Created attachment 41638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41638&action=edit Bug : View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * '<a href="?branch=BRANCH1">BRANCH1</a>' * '<a href="?branch=">none</a>' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |xarragon@gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #2 from Martin Persson <xarragon@gmail.com> --- Created attachment 41639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41639&action=edit Bug 14305: View arbitrary branch's news, RSS fix This fix changes the RSS link to reflect the URL paramter override. This is less elegant than the existing solution which uses the Branches TT module, perhaps there is a better way? Sponsored-By: Halland County Library Test plan: * Follow instructions in the original patch but also check the URLs and contents of the RSS link at the bottom the OPAC page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14764 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764 [Bug 14764] Add OPAC News branch selector -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #3 from Martin Persson <xarragon@gmail.com> --- *** Bug 14764 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41638|0 |1 is obsolete| | --- Comment #4 from Martin Persson <xarragon@gmail.com> --- Created attachment 45650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45650&action=edit Bug 14305: View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * '<a href="?branch=BRANCH1">BRANCH1</a>' * '<a href="?branch=">none</a>' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #5 from Martin Persson <xarragon@gmail.com> --- This ticket overlapped a bit in functionality and actual code with 14764. I am cleaning up both now and marking them properly. This patch only reads the branch from the URL; the user has to create the URLs themselves. This separation is a bit stupid, but the tickets were created before I was familiar with what was practical. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45650|0 |1 is obsolete| | --- Comment #6 from Martin Persson <xarragon@gmail.com> --- Created attachment 45673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45673&action=edit Bug 14305: View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * '<a href="?branch=BRANCH1">BRANCH1</a>' * '<a href="?branch=">none</a>' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14305 Changed 2015-12-14: Whitespace fix -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org